commit 6cebfc13ccdcd9cb2a5b576fa369b957e651752a
author Mark Payne <markap14@hotmail.com> Wed Jul 27 20:23:13 2016 -0400
committer Mark Payne <markap14@hotmail.com> Wed Jul 27 20:23:13 2016 -0400
tree 3f6adc31c11f44d5f767a18af23b4a454b9d1cc0
parent ba85368e9aa461320071fb872f02b5c3b6619c14

CURATOR-337: Do not attempt to release a mutex unless it has actually been acquired

curator-recipes/src/main/java/org/apache/curator/framework/recipes/leader/LeaderSelector.java

diff --git a/curator-recipes/src/main/java/org/apache/curator/framework/recipes/leader/LeaderSelector.java b/curator-recipes/src/main/java/org/apache/curator/framework/recipes/leader/LeaderSelector.java
index ec33533..c177302 100644
--- a/curator-recipes/src/main/java/org/apache/curator/framework/recipes/leader/LeaderSelector.java
+++ b/curator-recipes/src/main/java/org/apache/curator/framework/recipes/leader/LeaderSelector.java
@@ -419,16 +419,19 @@
         }
         finally
         {
-            hasLeadership = false;
-            try
+            if ( hasLeadership )
             {
-                mutex.release();
-            }
-            catch ( Exception e )
-            {
-                ThreadUtils.checkInterrupted(e);
-                log.error("The leader threw an exception", e);
-                // ignore errors - this is just a safety
+                hasLeadership = false;
+                try
+                {
+                    mutex.release();
+                }
+                catch ( Exception e )
+                {
+                    ThreadUtils.checkInterrupted(e);
+                    log.error("The leader threw an exception", e);
+                    // ignore errors - this is just a safety
+                }
             }
         }
     }