commit e5f2e43d6ee89334bb168d888715431bc9badaaf
author Glynn Bird <glynn.bird@gmail.com> Mon Jul 08 08:24:12 2019 +0100
committer GitHub <noreply@github.com> Mon Jul 08 08:24:12 2019 +0100
tree f3510f9f2334d3440ade16e3629e1bf291730eb5
parent b080a4858876c2d778aba0907ab1445281c2347b

get attachment should return a Buffer (#173)

.npmignore

diff --git a/.npmignore b/.npmignore
index 75d43a3..69ef77e 100644
--- a/.npmignore
+++ b/.npmignore
@@ -1,2 +1,5 @@
 tests
 scripts
+examples
+coverage
+.github

lib/nano.d.ts

diff --git a/lib/nano.d.ts b/lib/nano.d.ts
index 506ecaa..ca5a29f 100644
--- a/lib/nano.d.ts
+++ b/lib/nano.d.ts
@@ -350,14 +350,14 @@
       contenttype: string,
       params: any
     ): Request
-    get(docname: string, attname: string, callback?: Callback<any>): Promise<any>;
+    get(docname: string, attname: string, callback?: Callback<Buffer>): Promise<Buffer>;
     getAsStream(docname: string, attname: string): Request;
     get(
       docname: string,
       attname: string,
       params: any,
-      callback?: Callback<any>
-    ): Promise<any>;
+      callback?: Callback<Buffer>
+    ): Promise<Buffer>;
     destroy(docname: string, attname: string, callback?: Callback<any>): Promise<any>;
     destroy(
       docname: string,

lib/nano.js

diff --git a/lib/nano.js b/lib/nano.js
index 8522a30..d73e634 100644
--- a/lib/nano.js
+++ b/lib/nano.js
@@ -226,7 +226,7 @@
     }
 
     // prevent bugs where people set encoding when piping
-    if (opts.encoding !== undefined && callback) {
+    if (opts.encoding !== undefined) {
       req.encoding = opts.encoding
       delete req.headers['content-type']
       delete req.headers.accept