Merge pull request #12 from rodo/master
Remove non needed clause in ranks_of/5
diff --git a/src/bear.erl b/src/bear.erl
index ffc9025..04593e7 100644
--- a/src/bear.erl
+++ b/src/bear.erl
@@ -278,8 +278,6 @@
end, [], Values),
lists:reverse(L).
-ranks_of([E|Es],Acc, N, E, S) ->
- ranks_of(Es, Acc, N+1, E, S);
ranks_of([E|Es], Acc, N, P, S) ->
ranks_of(Es,[{P,(S+N-1)/2}|Acc], N+1, E, N);
ranks_of([], Acc, N, P, S) ->
diff --git a/test/bear_test.erl b/test/bear_test.erl
index 10d447c..2cca076 100644
--- a/test/bear_test.erl
+++ b/test/bear_test.erl
@@ -173,6 +173,11 @@
?assertEqual(1.0, bear:get_pearson_correlation(lists:seq(0,10), lists:seq(5,15))),
?assertEqual(1.0, bear:get_pearson_correlation(lists:seq(40,60,2), lists:seq(10,20))).
+get_pearson_correlation_nullresult_test() ->
+ %% The two series do not correlate
+ A = [-1,-0.5,0,0.5,1],
+ B = [1,0.25,0,0.25,1],
+ ?assertEqual(0.0, bear:get_pearson_correlation(A, B)).
round_bin_test() ->
?assertEqual(10, bear:round_bin(10)),
