commit f4f1abec3a0f5e5efd1ec8bc8312c97ad92deefa
author Ken'ichi Fukushima <ken.fukushima@gmail.com> Mon Sep 12 18:28:49 2016 +0900
committer Julio César <jcesarmobile@gmail.com> Thu Dec 29 00:26:44 2016 +0100
tree 241f84bd940c40b5400d6be86b11c28c9986ef70
parent ee0cb16e585bda6cfa5e382544b9ef4ef01080b0

CB-11838 ios: Unregister callback function at the right timing.

We at LINE observed about 40K crashes a day that were suspected to be
caused by the reacahability callback function invoked on an
already-deallocated object. We couldn't reproduced the crash locally
but this patch did reduce the number of crash reports to zero.

 This closes #49

src/ios/CDVReachability.m

diff --git a/src/ios/CDVReachability.m b/src/ios/CDVReachability.m
index 70177a7..b43a62d 100644
--- a/src/ios/CDVReachability.m
+++ b/src/ios/CDVReachability.m
@@ -120,6 +120,7 @@
 - (void)stopNotifier
 {
     if (reachabilityRef != NULL) {
+        SCNetworkReachabilitySetCallback(reachabilityRef, NULL, NULL);
         SCNetworkReachabilityUnscheduleFromRunLoop(reachabilityRef, CFRunLoopGetCurrent(), kCFRunLoopDefaultMode);
     }
 }