fix: Typo in Build: `Singning` -> `Signing` (#75)
diff --git a/bin/templates/cordova/lib/build.js b/bin/templates/cordova/lib/build.js
index 3633582..5662567 100644
--- a/bin/templates/cordova/lib/build.js
+++ b/bin/templates/cordova/lib/build.js
@@ -148,11 +148,11 @@
}
if (platformConfigs.signing) {
- this.__appendUserSingning(platform, platformConfigs.signing, userBuildSettings);
+ this.__appendUserSigning(platform, platformConfigs.signing, userBuildSettings);
}
}
- __appendUserSingning (platform, signingConfigs, userBuildSettings) {
+ __appendUserSigning (platform, signingConfigs, userBuildSettings) {
if (platform === 'linux') {
events.emit('warn', `The provided signing information for the Linux platform is ignored. Linux does not support signing.`);
return this;
@@ -160,18 +160,18 @@
const config = this.isDevelopment ? signingConfigs.debug : signingConfigs.release;
if (platform === 'mac' && config) {
- this.__appendMacUserSingning(config, userBuildSettings.config.mac);
+ this.__appendMacUserSigning(config, userBuildSettings.config.mac);
}
const masConfig = this.isDevelopment ? null : (signingConfigs.store || null);
if (platform === 'mac' && masConfig) {
// Requirements is not available for mas.
if (masConfig.requirements) delete masConfig.requirements;
- this.__appendMacUserSingning(masConfig, userBuildSettings.config.mas);
+ this.__appendMacUserSigning(masConfig, userBuildSettings.config.mas);
}
if (platform === 'win' && config) {
- this.__appendWindowsUserSingning(config, userBuildSettings.config.win);
+ this.__appendWindowsUserSigning(config, userBuildSettings.config.win);
}
}
@@ -183,7 +183,7 @@
);
}
- __appendMacUserSingning (config, buildConfigs) {
+ __appendMacUserSigning (config, buildConfigs) {
if (config.identity || process.env.CSC_LINK || process.env.CSC_NAME) buildConfigs.identity = config.identity || process.env.CSC_LINK || process.env.CSC_NAME;
const entitlements = config.entitlements;
@@ -215,7 +215,7 @@
}
}
- __appendWindowsUserSingning (config, buildConfigs) {
+ __appendWindowsUserSigning (config, buildConfigs) {
const certificateFile = config.certificateFile;
if (certificateFile && fs.existsSync(certificateFile)) {
buildConfigs.certificateFile = certificateFile;
diff --git a/tests/spec/unit/templates/cordova/lib/build.spec.js b/tests/spec/unit/templates/cordova/lib/build.spec.js
index eab406f..f80527a 100644
--- a/tests/spec/unit/templates/cordova/lib/build.spec.js
+++ b/tests/spec/unit/templates/cordova/lib/build.spec.js
@@ -879,7 +879,7 @@
expect(function () { electronBuilder.fetchPlatformDefaults('name'); }).toThrow(new Error('Your platform "name" is not supported as a default target platform for Electron.'));
});
- it('should __appendUserSingning linux signing.', () => {
+ it('should __appendUserSigning linux signing.', () => {
// mock platformConfig, buildConfig and buildOptions Objects
const platformConfig = {
linux: { package: ['package', 'package2'], signing: { debug: 'debug', release: 'release' } }
@@ -901,7 +901,7 @@
existsSyncSpy = jasmine.createSpy('existsSync').and.returnValue(false);
build.__set__('fs', { existsSync: existsSyncSpy });
- electronBuilder = new ElectronBuilder(buildOptions, api).__appendUserSingning('linux', platformConfig.linux.signing, buildOptions);
+ electronBuilder = new ElectronBuilder(buildOptions, api).__appendUserSigning('linux', platformConfig.linux.signing, buildOptions);
expect(existsSyncSpy).toHaveBeenCalled();
expect(emitSpy).toHaveBeenCalled();
@@ -910,7 +910,7 @@
expect(actual).toEqual(expected);
});
- it('should __appendUserSingning mac with masconfig.', () => {
+ it('should __appendUserSigning mac with masconfig.', () => {
// mock platformConfig, buildConfig and buildOptions Objects
const platformConfig = {
mac: { package: ['package', 'package2'], signing: { store: { requirements: 'requirements' } } }
@@ -933,7 +933,7 @@
existsSyncSpy = jasmine.createSpy('existsSync').and.returnValue(false);
build.__set__('fs', { existsSync: existsSyncSpy });
- electronBuilder = new ElectronBuilder(buildOptions, api).__appendUserSingning('mac', platformConfig.mac.signing, buildOptions);
+ electronBuilder = new ElectronBuilder(buildOptions, api).__appendUserSigning('mac', platformConfig.mac.signing, buildOptions);
expect(existsSyncSpy).toHaveBeenCalled();
expect(buildOptions.buildConfig.electron.mac.signing.store.requirements).toBe(undefined);
@@ -961,12 +961,12 @@
existsSyncSpy = jasmine.createSpy('existsSync').and.returnValue(false);
build.__set__('fs', { existsSync: existsSyncSpy });
- electronBuilder = new ElectronBuilder(buildOptions, api).__appendUserSingning('win', platformConfig, buildOptions);
+ electronBuilder = new ElectronBuilder(buildOptions, api).__appendUserSigning('win', platformConfig, buildOptions);
expect(existsSyncSpy).toHaveBeenCalled();
});
- it('should set buildConfigs __appendMacUserSingning when files exist.', () => {
+ it('should set buildConfigs __appendMacUserSigning when files exist.', () => {
// mock platformConfig, buildConfig and buildOptions Objects
const platformConfig = {
darwin: { package: ['package', 'package2'], signing: { debug: 'debug', release: 'release', store: { requirements: 'requirements' } } }
@@ -999,7 +999,7 @@
existsSyncSpy = jasmine.createSpy('existsSync').and.returnValue(true);
build.__set__('fs', { existsSync: existsSyncSpy });
- electronBuilder = new ElectronBuilder(buildOptions, api).__appendMacUserSingning(config, buildConfig);
+ electronBuilder = new ElectronBuilder(buildOptions, api).__appendMacUserSigning(config, buildConfig);
expect(existsSyncSpy).toHaveBeenCalled();
expect(buildConfig.identity).toEqual(config.identity);
@@ -1009,7 +1009,7 @@
expect(buildConfig.provisioningProfile).toEqual(config.provisioningProfile);
});
- it('should emit warning when in __appendMacUserSingning when files does not exist and set identity to process env link.', () => {
+ it('should emit warning when in __appendMacUserSigning when files does not exist and set identity to process env link.', () => {
// mock platformConfig, buildConfig and buildOptions Objects
const platformConfig = {
darwin: { package: ['package', 'package2'], signing: { debug: 'debug', release: 'release', store: { requirements: 'requirements' } } }
@@ -1044,7 +1044,7 @@
existsSyncSpy = jasmine.createSpy('existsSync').and.returnValue(false);
build.__set__('fs', { existsSync: existsSyncSpy });
- electronBuilder = new ElectronBuilder(buildOptions, api).__appendMacUserSingning(config, buildConfig);
+ electronBuilder = new ElectronBuilder(buildOptions, api).__appendMacUserSigning(config, buildConfig);
expect(existsSyncSpy).toHaveBeenCalled();
expect(emitSpy).toHaveBeenCalled();
@@ -1072,7 +1072,7 @@
expect(actualProvisioningProfile).toContain(expectedProvisioningProfiles);
});
- it('should emit warning when in __appendMacUserSingning when files does not exist and set identity to process env name.', () => {
+ it('should emit warning when in __appendMacUserSigning when files does not exist and set identity to process env name.', () => {
// mock platformConfig, buildConfig and buildOptions Objects
const platformConfig = {
darwin: { package: ['package', 'package2'], signing: { debug: 'debug', release: 'release', store: { requirements: 'requirements' } } }
@@ -1107,7 +1107,7 @@
existsSyncSpy = jasmine.createSpy('existsSync').and.returnValue(false);
build.__set__('fs', { existsSync: existsSyncSpy });
- electronBuilder = new ElectronBuilder(buildOptions, api).__appendMacUserSingning(config, buildConfig);
+ electronBuilder = new ElectronBuilder(buildOptions, api).__appendMacUserSigning(config, buildConfig);
expect(existsSyncSpy).toHaveBeenCalled();
expect(emitSpy).toHaveBeenCalled();
@@ -1135,7 +1135,7 @@
expect(actualProvisioningProfile).toContain(expectedProvisioningProfiles);
});
- it('should set buildConfigs in __appendWindowsUserSingning for windows singning when files exist.', () => {
+ it('should set buildConfigs in __appendWindowsUserSigning for windows singning when files exist.', () => {
// mock platformConfig, buildConfig and buildOptions Objects
const platformConfig = {
windows: { package: ['package', 'package2'], signing: { debug: 'debug', release: 'release', store: 'requirements' } }
@@ -1169,7 +1169,7 @@
existsSyncSpy = jasmine.createSpy('existsSync').and.returnValue(true);
build.__set__('fs', { existsSync: existsSyncSpy });
- electronBuilder = new ElectronBuilder(buildOptions, api).__appendWindowsUserSingning(config, buildConfig);
+ electronBuilder = new ElectronBuilder(buildOptions, api).__appendWindowsUserSigning(config, buildConfig);
expect(existsSyncSpy).toHaveBeenCalled();
@@ -1181,7 +1181,7 @@
expect(buildConfig.additionalCertificateFile).toEqual(config.additionalCertificateFile);
});
- it('should set buildConfigs in __appendWindowsUserSingning for windows singning when files exist, but certificate password does not.', () => {
+ it('should set buildConfigs in __appendWindowsUserSigning for windows singning when files exist, but certificate password does not.', () => {
// mock platformConfig, buildConfig and buildOptions Objects
const platformConfig = {
windows: { package: ['package', 'package2'], signing: { debug: 'debug', release: 'release', store: 'requirements' } }
@@ -1217,7 +1217,7 @@
existsSyncSpy = jasmine.createSpy('existsSync').and.returnValue(true);
build.__set__('fs', { existsSync: existsSyncSpy });
- electronBuilder = new ElectronBuilder(buildOptions, api).__appendWindowsUserSingning(config, buildConfig);
+ electronBuilder = new ElectronBuilder(buildOptions, api).__appendWindowsUserSigning(config, buildConfig);
expect(existsSyncSpy).toHaveBeenCalled();
@@ -1229,7 +1229,7 @@
expect(buildConfig.additionalCertificateFile).toEqual(config.additionalCertificateFile);
});
- it('should set buildConfigs in __appendWindowsUserSingning for windows singning when files exist, but certificate and process env password does not.', () => {
+ it('should set buildConfigs in __appendWindowsUserSigning for windows singning when files exist, but certificate and process env password does not.', () => {
// mock platformConfig, buildConfig and buildOptions Objects
const platformConfig = {
windows: { package: ['package', 'package2'], signing: { debug: 'debug', release: 'release', store: 'requirements' } }
@@ -1262,7 +1262,7 @@
existsSyncSpy = jasmine.createSpy('existsSync').and.returnValue(true);
build.__set__('fs', { existsSync: existsSyncSpy });
- electronBuilder = new ElectronBuilder(buildOptions, api).__appendWindowsUserSingning(config, buildConfig);
+ electronBuilder = new ElectronBuilder(buildOptions, api).__appendWindowsUserSigning(config, buildConfig);
expect(existsSyncSpy).toHaveBeenCalled();
@@ -1274,7 +1274,7 @@
expect(buildConfig.additionalCertificateFile).toEqual(config.additionalCertificateFile);
});
- it('should set buildConfigs in __appendWindowsUserSingning for windows singning when files does not exist.', () => {
+ it('should set buildConfigs in __appendWindowsUserSigning for windows singning when files does not exist.', () => {
// mock platformConfig, buildConfig and buildOptions Objects
const platformConfig = {
windows: { package: ['package', 'package2'], signing: { debug: 'debug', release: 'release', store: 'requirements' } }
@@ -1308,7 +1308,7 @@
existsSyncSpy = jasmine.createSpy('existsSync').and.returnValue(false);
build.__set__('fs', { existsSync: existsSyncSpy });
- electronBuilder = new ElectronBuilder(buildOptions, api).__appendWindowsUserSingning(config, buildConfig);
+ electronBuilder = new ElectronBuilder(buildOptions, api).__appendWindowsUserSigning(config, buildConfig);
expect(existsSyncSpy).toHaveBeenCalled();
expect(emitSpy).toHaveBeenCalled();
