commit 6b60c905af987b3a57865e42c07683089ff4c63a
author Andrew Grieve <agrieve@chromium.org> Mon Dec 22 10:21:17 2014 -0500
committer Ajitha <ajithas@amazon.com> Mon Jan 05 05:50:31 2015 +0000
tree 987fe8912382a335cbcb60af16e6888c3e92a7aa
parent 11b2b1f43febe74f6955576c2ddb9fea12ba90fe

CB-8202 Fix gradle build signing when passwords provided interactively

bin/templates/project/build.gradle

diff --git a/bin/templates/project/build.gradle b/bin/templates/project/build.gradle
index f427561..a2ebaf5 100644
--- a/bin/templates/project/build.gradle
+++ b/bin/templates/project/build.gradle
@@ -107,9 +107,9 @@
             release {
                 // These must be set or Gradle will complain (even if they are overridden).
                 keyAlias = ""
-                keyPassword = ""
+                keyPassword = "__unset" // And these must be set to non-empty in order to have the signing step added to the task graph.
                 storeFile = null
-                storePassword = ""
+                storePassword = "__unset"
             }
         }
         buildTypes {
@@ -159,11 +159,10 @@
     if (!System.env.RELEASE_SIGNING_PROPERTIES_FILE) {
         return;
     }
-    if (!android.signingConfigs.release.storePassword) {
+    if ('__unset'.equals(android.signingConfigs.release.storePassword)) {
         android.signingConfigs.release.storePassword = promptForPassword('Enter key store password: ')
-        println('set to:' + android.signingConfigs.release.storePassword)
     }
-    if (!android.signingConfigs.release.keyPassword) {
+    if ('__unset'.equals(android.signingConfigs.release.keyPassword)) {
         android.signingConfigs.release.keyPassword = promptForPassword('Enter key password: ');
     }
 }
@@ -205,9 +204,9 @@
         throw new FileNotFoundException('Keystore file does not exist: ' + storeFile.getAbsolutePath())
     }
     signingConfig.keyAlias = ensureValueExists(propsFilePath, props, 'keyAlias')
-    signingConfig.keyPassword = props.get('keyPassword')
+    signingConfig.keyPassword = props.get('keyPassword', signingConfig.keyPassword)
     signingConfig.storeFile = storeFile
-    signingConfig.storePassword = props.get('storePassword')
+    signingConfig.storePassword = props.get('storePassword', signingConfig.storePassword)
     def storeType = props.get('storeType')
     if (!storeType) {
         def filename = storeFile.getName().toLowerCase();