Add @SuppressWarnings and use avoid naming confusion b/w File and
FileObject.
diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/cache/LRUFilesCache.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/cache/LRUFilesCache.java
index 76b8ae9..0fa6a7b 100644
--- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/cache/LRUFilesCache.java
+++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/cache/LRUFilesCache.java
@@ -78,11 +78,12 @@
@Override
protected boolean removeLRU(final AbstractLinkedMap.LinkEntry<FileName, FileObject> linkEntry) {
synchronized (LRUFilesCache.this) {
- final FileObject file = linkEntry.getValue();
+ @SuppressWarnings("resource") // FileObject allocated elsewhere.
+ final FileObject fileObject = linkEntry.getValue();
// System.err.println(">>> " + size() + " check removeLRU:" + linkEntry.getKey().toString());
- if (file.isAttached() || file.isContentOpen()) {
+ if (fileObject.isAttached() || fileObject.isContentOpen()) {
// do not allow open or attached files to be removed
// System.err.println(">>> " + size() + " VETO removeLRU:" +
// linkEntry.getKey().toString() + " (" + file.isAttached() + "/" +
@@ -94,7 +95,7 @@
if (super.removeLRU(linkEntry)) {
try {
// force detach
- file.close();
+ fileObject.close();
} catch (final FileSystemException e) {
VfsLog.warn(getLogger(), log, Messages.getString("vfs.impl/LRUFilesCache-remove-ex.warn"), e);
}
