commit 7bbea10702126a18ad01207d4763f73ec9ed07c3
author Bruno P. Kinoshita <kinow@users.noreply.github.com> Wed Apr 28 23:44:29 2021 +1200
committer Bruno P. Kinoshita <kinow@users.noreply.github.com> Wed Apr 28 23:44:29 2021 +1200
tree 7748ecfa0c0ec3d9602d95355fe2a0322e19c2c4
parent ef7d1249a14bbc0e13b8ed0e4e704d730f6abf66
parent 9ea65ab1ca4af7e5ed163b0074655412757da67f

Merge branch 'pr-230'

This closes #230

src/changes/changes.xml

diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 4c78e19..c4b0cde 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -84,6 +84,7 @@
     <action issue="TEXT-204" type="update" dev="kinow" due-to="Arturo Bernal">Use static class inner class in tests.</action>
     <action issue="TEXT-201" type="update" dev="kinow" due-to="Arturo Bernal">Simplify assertion.</action>
     <action issue="TEXT-202" type="update" dev="kinow" due-to="Arturo Bernal">Extract duplicate code.</action>
+    <action issue="TEXT-205" type="update" dev="kinow" due-to="Arturo Bernal">Set void return method.</action>
   </release>
   <release version="1.9" date="2020-07-21" description="Release 1.9. Requires Java 8.">
     <action issue="TEXT-166" type="fix" dev="kinow" due-to="Mikko Maunu">Removed non-existing parameter from Javadocs and spelled out parameters in throws.</action>

src/main/java/org/apache/commons/text/ExtendedMessageFormat.java

diff --git a/src/main/java/org/apache/commons/text/ExtendedMessageFormat.java b/src/main/java/org/apache/commons/text/ExtendedMessageFormat.java
index de45715..f24efb7 100644
--- a/src/main/java/org/apache/commons/text/ExtendedMessageFormat.java
+++ b/src/main/java/org/apache/commons/text/ExtendedMessageFormat.java
@@ -516,9 +516,8 @@
      * @param pattern pattern to parse
      * @param pos current parse position
      * @param appendTo optional StringBuilder to append
-     * @return {@code appendTo}
      */
-    private StringBuilder appendQuotedString(final String pattern, final ParsePosition pos,
+    private void appendQuotedString(final String pattern, final ParsePosition pos,
             final StringBuilder appendTo) {
         assert pattern.toCharArray()[pos.getIndex()] == QUOTE
                 : "Quoted string must start with quote character";
@@ -535,8 +534,10 @@
             switch (c[pos.getIndex()]) {
             case QUOTE:
                 next(pos);
-                return appendTo == null ? null : appendTo.append(c, start,
-                        pos.getIndex() - start);
+                if (appendTo != null) {
+                    appendTo.append(c, start, pos.getIndex() - start);
+                }
+                return;
             default:
                 next(pos);
             }