commit 880304dde41e6711b906df85b6e1eed3492f714c
author aherbert <aherbert@apache.org> Mon Jun 29 15:38:54 2020 +0100
committer aherbert <aherbert@apache.org> Mon Jun 29 15:38:54 2020 +0100
tree b93e94641c3bd31c4d6cc6b59746afa3ca63e090
parent 6425b89d12fbe3f0458b9a637b0881e27434b71a

PMD fix: avoid literals in conditional statement

commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/TDistribution.java

diff --git a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/TDistribution.java b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/TDistribution.java
index 0b9627f..5f74ff5 100644
--- a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/TDistribution.java
+++ b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/TDistribution.java
@@ -23,6 +23,9 @@
  * Implementation of <a href='http://en.wikipedia.org/wiki/Student&apos;s_t-distribution'>Student's t-distribution</a>.
  */
 public class TDistribution extends AbstractContinuousDistribution {
+    /** 2. */
+    private static final double TWO = 2;
+
     /** The degrees of freedom. */
     private final double degreesOfFreedom;
     /** degreesOfFreedom / 2. */
@@ -51,7 +54,7 @@
         factor = LogGamma.value(dofOver2 + 0.5) -
                  0.5 * (Math.log(Math.PI) + Math.log(degreesOfFreedom)) -
                  LogGamma.value(dofOver2);
-        if (degreesOfFreedom > 2) {
+        if (degreesOfFreedom > TWO) {
             mean = 0;
             variance = degreesOfFreedom / (degreesOfFreedom - 2);
         } else if (degreesOfFreedom > 1) {