commit | 7db9d2210ce62879353780f8447e7e9f6255e493 | [log] [tgz] |
---|---|---|
author | Alex Herbert <aherbert@apache.org> | Fri Jul 30 21:29:44 2021 +0100 |
committer | Alex Herbert <aherbert@apache.org> | Fri Jul 30 21:29:44 2021 +0100 |
tree | c50ff76e2844f6fe7bc8d5ef33fb692ba9a5a65a | |
parent | 8f79a54704ed1bc1d5555736e7894d5f4cafa16f [diff] |
Simplify probability using logProbability
diff --git a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/BinomialDistribution.java b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/BinomialDistribution.java index 506a73a..d9dcc64 100644 --- a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/BinomialDistribution.java +++ b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/BinomialDistribution.java
@@ -71,8 +71,7 @@ /** {@inheritDoc} */ @Override public double probability(int x) { - final double logProbability = logProbability(x); - return logProbability == Double.NEGATIVE_INFINITY ? 0 : Math.exp(logProbability); + return Math.exp(logProbability(x)); } /** {@inheritDoc} **/
diff --git a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/HypergeometricDistribution.java b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/HypergeometricDistribution.java index 7ccb411..6dc6a6a 100644 --- a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/HypergeometricDistribution.java +++ b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/HypergeometricDistribution.java
@@ -129,8 +129,7 @@ /** {@inheritDoc} */ @Override public double probability(int x) { - final double logProbability = logProbability(x); - return logProbability == Double.NEGATIVE_INFINITY ? 0 : Math.exp(logProbability); + return Math.exp(logProbability(x)); } /** {@inheritDoc} */
diff --git a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/PoissonDistribution.java b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/PoissonDistribution.java index 8444627..bef39c6 100644 --- a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/PoissonDistribution.java +++ b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/PoissonDistribution.java
@@ -75,8 +75,7 @@ /** {@inheritDoc} */ @Override public double probability(int x) { - final double logProbability = logProbability(x); - return logProbability == Double.NEGATIVE_INFINITY ? 0 : Math.exp(logProbability); + return Math.exp(logProbability(x)); } /** {@inheritDoc} */