commit 63f0f63e315af66a521ea60627993b3e4b4208f8
author aherbert <aherbert@apache.org> Thu Sep 26 15:35:03 2019 +0100
committer aherbert <aherbert@apache.org> Thu Sep 26 15:35:03 2019 +0100
tree 43cfc3e920aa85d7c6984fe0a02cc8371aa78a71
parent 01b25d4d0a552bbe6a0e7b877f8b15db2585b6ed

Reduce RandomSourceInternal method scope where possible.

commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/ProviderBuilder.java

diff --git a/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/ProviderBuilder.java b/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/ProviderBuilder.java
index 02af9fc..d9e394e 100644
--- a/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/ProviderBuilder.java
+++ b/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/ProviderBuilder.java
@@ -256,12 +256,12 @@
              3,
              NativeSeedType.LONG_ARRAY) {
             @Override
-            Object createSeed() {
+            protected Object createSeed() {
                 return createMswsSeed(SeedFactory.createLong());
             }
 
             @Override
-            Object convertSeed(Object seed) {
+            protected Object convertSeed(Object seed) {
                 // Allow seeding with primitives to generate a good seed
                 if (seed instanceof Integer) {
                     return createMswsSeed((Integer) seed);
@@ -474,7 +474,7 @@
          *
          * @return the native seed
          */
-        Object createSeed() {
+        protected Object createSeed() {
             return nativeSeedType.createSeed(nativeSeedSize);
         }
 
@@ -496,11 +496,15 @@
         /**
          * Converts a seed from any of the supported seed types to a native seed.
          *
+         * <p>The default implementation delegates to the native seed type conversion.</p>
+         *
+         * <p>This method should be over-ridden to satisfy seed requirements for the generator.</p>
+         *
          * @param seed Input seed (must not be null).
          * @return the native seed
          * @throw UnsupportedOperationException if the {@code seed} type is invalid.
          */
-        Object convertSeed(Object seed) {
+        protected Object convertSeed(Object seed) {
             return nativeSeedType.convertSeed(seed, nativeSeedSize);
         }