Update to commons-parent 54
Remove javadoc links. The links configured in CP create redirect
warnings on JDK 17 which fail the build. JDK links are automatically
added by the javadoc plugin based on the target version.
Suppress spotbugs errors from intentional use of floating-point loop
counters.
Disable CycloneDX as config is incorrect for multi-module builds.
diff --git a/pom.xml b/pom.xml
index d6c3f65..6af9e2d 100644
--- a/pom.xml
+++ b/pom.xml
@@ -20,7 +20,7 @@
<parent>
<groupId>org.apache.commons</groupId>
<artifactId>commons-parent</artifactId>
- <version>53</version>
+ <version>54</version>
</parent>
<artifactId>commons-rng-parent</artifactId>
@@ -65,6 +65,8 @@
<rng.junit5.version>5.7.2</rng.junit5.version>
<!-- Workaround to avoid duplicating config files. -->
<rng.parent.dir>${basedir}</rng.parent.dir>
+ <!-- Multi-module support fixed in commons-parent 55 -->
+ <cyclonedx.skip>true</cyclonedx.skip>
<!-- Fix to avoid JXR 3.0.0 forking the lifecycle phase 'compile' during site report
jxr:aggregate. If compile is forked it fails when building the Java 9 modules that
@@ -360,6 +362,8 @@
<exclude>**/*.patch</exclude>
<exclude>**/pdf.*.txt</exclude>
<exclude>src/main/resources/revapi/api-changes.json</exclude>
+ <!-- Moved to commons-parent 55 -->
+ <exclude>.gitattributes</exclude>
</excludes>
</configuration>
</plugin>
@@ -369,6 +373,10 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<configuration>
+ <!-- Java API links configured in commons-parent create redirect warnings on JDK 17
+ and fail the build. The links are not required as detectJavaApiLink=true (default). -->
+ <links combine.self="override">
+ </links>
<failOnWarnings>true</failOnWarnings>
<!-- Enable MathJax -->
<additionalOptions>${doclint.javadoc.qualifier} ${allowscript.javadoc.qualifier} -header '<script type="text/javascript" async src="${rng.mathjax.url}"></script>'</additionalOptions>
@@ -407,6 +415,8 @@
<exclude>dist-archive/**</exclude>
<exclude>**/*.patch</exclude>
<exclude>**/pdf.*.txt</exclude>
+ <!-- Moved to commons-parent 55 -->
+ <exclude>.gitattributes</exclude>
</excludes>
</configuration>
</plugin>
@@ -504,6 +514,10 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<configuration>
+ <!-- Java API links configured in commons-parent create redirect warnings on JDK 17
+ and fail the build. The links are not required as detectJavaApiLink=true (default). -->
+ <links combine.self="override">
+ </links>
<failOnWarnings>true</failOnWarnings>
<!-- Enable MathJax -->
<additionalOptions>${doclint.javadoc.qualifier} ${allowscript.javadoc.qualifier} -header '<script type="text/javascript" async src="${rng.mathjax.url}"></script>'</additionalOptions>
diff --git a/src/main/resources/spotbugs/spotbugs-exclude-filter.xml b/src/main/resources/spotbugs/spotbugs-exclude-filter.xml
index 0d4dc20..6ed1144 100644
--- a/src/main/resources/spotbugs/spotbugs-exclude-filter.xml
+++ b/src/main/resources/spotbugs/spotbugs-exclude-filter.xml
@@ -129,4 +129,19 @@
<BugPattern name="DMI_RANDOM_USED_ONLY_ONCE"/>
</Match>
+ <!-- Use of floating-point loop counters is intentional. -->
+ <Match>
+ <Class name="org.apache.commons.rng.sampling.distribution.AhrensDieterExponentialSampler"/>
+ <Method name="sample"/>
+ <BugPattern name="FL_FLOATS_AS_LOOP_COUNTERS"/>
+ </Match>
+ <Match>
+ <Class name="org.apache.commons.rng.sampling.distribution.MarsagliaTsangWangDiscreteSampler$Poisson"/>
+ <Or>
+ <Method name="createPoissonDistributionFromX0"/>
+ <Method name="createPoissonDistributionFromXMode"/>
+ </Or>
+ <BugPattern name="FL_FLOATS_AS_LOOP_COUNTERS"/>
+ </Match>
+
</FindBugsFilter>
