commit 12e46c6ab0552c3589e2e3e4d7972cae7cada864
author Gary Gregory <ggregory@rocketsoftware.com> Thu Mar 10 11:04:29 2022 -0500
committer Gary Gregory <ggregory@rocketsoftware.com> Thu Mar 10 11:04:29 2022 -0500
tree e2faa7e03774cace92c44d8e6741d4fd11406f26
parent a131e3d38412b837c32c434fa327dc22fa430ddf

Add commented out hack to workaround Maven breakage.

https://issues.apache.org/jira/browse/MNG-7316

src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionDetachmentMojo.java

diff --git a/src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionDetachmentMojo.java b/src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionDetachmentMojo.java
index 30aad8c..c24e82c 100755
--- a/src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionDetachmentMojo.java
+++ b/src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionDetachmentMojo.java
@@ -113,8 +113,7 @@
     @Override
     public void execute() throws MojoExecutionException {
         if (!isDistModule) {
-            getLog().info(
-                    "This module is marked as a non distribution or assembly module, and the plugin will not run.");
+            getLog().info("This module is marked as a non distribution or assembly module, and the plugin will not run.");
             return;
         }
         if (StringUtils.isEmpty(distSvnStagingUrl)) {
@@ -132,11 +131,27 @@
             getLog().info("Current project contains no distributions. Not executing.");
             return;
         }
+        //
+        // PROBLEM CODE for Maven >= 3.8.3
+        // https://issues.apache.org/jira/browse/MNG-7316
         for (final Artifact artifactToRemove : detachedArtifacts) {
             // Maven 3.8.3 throws an exception here because MavenProject.getAttachedArtifacts()
             // returns an IMMUTABLE collection.
             project.getAttachedArtifacts().remove(artifactToRemove);
         }
+        //
+        // HACK START to replace the above.
+        // https://issues.apache.org/jira/browse/MNG-7316
+//        final ArrayList<Artifact> arrayList = new ArrayList<>(project.getAttachedArtifacts());
+//        arrayList.removeAll(detachedArtifacts);
+//        try {
+//            // MavenProject#setAttachedArtifacts(List) is protected
+//            MethodUtils.invokeMethod(project, true, "setAttachedArtifacts", arrayList);
+//        } catch (ReflectiveOperationException e) {
+//            throw new MojoExecutionException(e);
+//        }
+        // HACK END
+        //
         if (!workingDirectory.exists()) {
             SharedFunctions.initDirectory(getLog(), workingDirectory);
         }