commit 1dad4a176279a608a655d8c4473463139f833c67
author aherbert <aherbert@apache.org> Wed Apr 08 12:11:12 2020 +0100
committer aherbert <aherbert@apache.org> Wed Apr 08 12:11:12 2020 +0100
tree 17384ee24d22a0476d4122b25e3c874f65143feb
parent d392058a78213e96f1218d26a10b9702cd9954e6

Add test for signum to fraction constructor tests

commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java

diff --git a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java
index a24a801..e3a611b 100644
--- a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java
+++ b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java
@@ -31,6 +31,9 @@
     private static void assertFraction(long expectedNumerator, long expectedDenominator, BigFraction actual) {
         Assertions.assertEquals(BigInteger.valueOf(expectedNumerator), actual.getNumerator());
         Assertions.assertEquals(BigInteger.valueOf(expectedDenominator), actual.getDenominator());
+        Assertions.assertEquals(
+            Long.signum(expectedNumerator) * Long.signum(expectedDenominator),
+            actual.signum());
     }
 
     private static void assertFraction(BigInteger expectedNumerator, BigInteger expectedDenominator, BigFraction actual) {

commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/CommonTestCases.java

diff --git a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/CommonTestCases.java b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/CommonTestCases.java
index 0938bcf..a421421 100644
--- a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/CommonTestCases.java
+++ b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/CommonTestCases.java
@@ -104,6 +104,7 @@
         testCases.add(new UnaryOperatorTestCase(1, -2, 1, -2));
         testCases.add(new UnaryOperatorTestCase(-2, 4, -1, 2));
         testCases.add(new UnaryOperatorTestCase(2, -4, 1, -2));
+        testCases.add(new UnaryOperatorTestCase(-2, -4, -1, -2));
 
         testCases.add(new UnaryOperatorTestCase(2, Integer.MIN_VALUE, 1, Integer.MIN_VALUE / 2));
         testCases.add(new UnaryOperatorTestCase(Integer.MIN_VALUE, -2, -Integer.MIN_VALUE / 2, -1));

commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java

diff --git a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java
index cf6e747..0888a75 100644
--- a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java
+++ b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java
@@ -30,6 +30,9 @@
     private void assertFraction(int expectedNumerator, int expectedDenominator, Fraction actual) {
         Assertions.assertEquals(expectedNumerator, actual.getNumerator());
         Assertions.assertEquals(expectedDenominator, actual.getDenominator());
+        Assertions.assertEquals(
+            Integer.signum(expectedNumerator) * Integer.signum(expectedDenominator),
+            actual.signum());
     }
 
     @Test
@@ -45,6 +48,7 @@
         // Special cases.
         assertFraction(Integer.MIN_VALUE, -1, Fraction.of(Integer.MIN_VALUE, -1));
         assertFraction(1, Integer.MIN_VALUE, Fraction.of(1, Integer.MIN_VALUE));
+        assertFraction(-1, Integer.MIN_VALUE, Fraction.of(-1, Integer.MIN_VALUE));
         assertFraction(1, 1, Fraction.of(Integer.MIN_VALUE, Integer.MIN_VALUE));
     }