commit 5a580fb9cbb669f87f124c455e56194b8f83da49
author Gary Gregory <garydgregory@gmail.com> Wed Sep 01 11:04:21 2021 -0400
committer Gary Gregory <garydgregory@gmail.com> Wed Sep 01 11:04:21 2021 -0400
tree 43b9d6166757856b8d8c1643d4b328b693c86e7c
parent 7f7c3d63c895d52fafd602459e269b92a6c93791

Use final, valueOf(), lambdas.

src/test/java/org/apache/commons/lang3/ArrayUtilsSetTest.java

diff --git a/src/test/java/org/apache/commons/lang3/ArrayUtilsSetTest.java b/src/test/java/org/apache/commons/lang3/ArrayUtilsSetTest.java
index 41b1b9b..e2cdd41 100644
--- a/src/test/java/org/apache/commons/lang3/ArrayUtilsSetTest.java
+++ b/src/test/java/org/apache/commons/lang3/ArrayUtilsSetTest.java
@@ -36,7 +36,7 @@
         assertArrayEquals(null, ArrayUtils.setAll(null, nullIntFunction));
         assertArrayEquals(ArrayUtils.EMPTY_BOOLEAN_OBJECT_ARRAY, ArrayUtils.setAll(ArrayUtils.EMPTY_BOOLEAN_OBJECT_ARRAY, nullIntFunction));
         assertArrayEquals(ArrayUtils.EMPTY_OBJECT_ARRAY, ArrayUtils.setAll(ArrayUtils.EMPTY_OBJECT_ARRAY, nullIntFunction));
-        Integer[] array = new Integer[10];
+        final Integer[] array = new Integer[10];
         final Integer[] array2 = ArrayUtils.setAll(array, Integer::valueOf);
         assertSame(array, array2);
         for (int i = 0; i < array.length; i++) {
@@ -51,10 +51,10 @@
         assertArrayEquals(null, ArrayUtils.setAll(null, nullSupplier));
         assertArrayEquals(ArrayUtils.EMPTY_BOOLEAN_OBJECT_ARRAY, ArrayUtils.setAll(ArrayUtils.EMPTY_BOOLEAN_OBJECT_ARRAY, nullSupplier));
         assertArrayEquals(ArrayUtils.EMPTY_OBJECT_ARRAY, ArrayUtils.setAll(ArrayUtils.EMPTY_OBJECT_ARRAY, nullSupplier));
-        String[] array = new String[10];
+        final String[] array = new String[10];
         final String[] array2 = ArrayUtils.setAll(array, () -> StringUtils.EMPTY);
         assertSame(array, array2);
-        for (String s : array) {
+        for (final String s : array) {
             assertEquals(StringUtils.EMPTY, s);
         }
     }

src/test/java/org/apache/commons/lang3/concurrent/UncheckedExecutionExceptionTest.java

diff --git a/src/test/java/org/apache/commons/lang3/concurrent/UncheckedExecutionExceptionTest.java b/src/test/java/org/apache/commons/lang3/concurrent/UncheckedExecutionExceptionTest.java
index 3763deb..00f104c 100644
--- a/src/test/java/org/apache/commons/lang3/concurrent/UncheckedExecutionExceptionTest.java
+++ b/src/test/java/org/apache/commons/lang3/concurrent/UncheckedExecutionExceptionTest.java
@@ -27,7 +27,7 @@
 
     @Test
     public void testConstructWithCause() {
-        Exception e = new Exception();
+        final Exception e = new Exception();
         assertSame(e, new UncheckedExecutionException(e).getCause());
     }
 

src/test/java/org/apache/commons/lang3/concurrent/UncheckedTimeoutExceptionTest.java

diff --git a/src/test/java/org/apache/commons/lang3/concurrent/UncheckedTimeoutExceptionTest.java b/src/test/java/org/apache/commons/lang3/concurrent/UncheckedTimeoutExceptionTest.java
index a3ac733..960ff02 100644
--- a/src/test/java/org/apache/commons/lang3/concurrent/UncheckedTimeoutExceptionTest.java
+++ b/src/test/java/org/apache/commons/lang3/concurrent/UncheckedTimeoutExceptionTest.java
@@ -27,7 +27,7 @@
 
     @Test
     public void testConstructWithCause() {
-        Exception e = new Exception();
+        final Exception e = new Exception();
         assertSame(e, new UncheckedTimeoutException(e).getCause());
     }
 

src/test/java/org/apache/commons/lang3/exception/UncheckedExceptionTest.java

diff --git a/src/test/java/org/apache/commons/lang3/exception/UncheckedExceptionTest.java b/src/test/java/org/apache/commons/lang3/exception/UncheckedExceptionTest.java
index 5b00531..fd5c2dc 100644
--- a/src/test/java/org/apache/commons/lang3/exception/UncheckedExceptionTest.java
+++ b/src/test/java/org/apache/commons/lang3/exception/UncheckedExceptionTest.java
@@ -27,7 +27,7 @@
 
     @Test
     public void testConstructWithCause() {
-        Exception e = new Exception();
+        final Exception e = new Exception();
         assertSame(e, new UncheckedException(e).getCause());
     }
 

src/test/java/org/apache/commons/lang3/exception/UncheckedInterruptedExceptionTest.java

diff --git a/src/test/java/org/apache/commons/lang3/exception/UncheckedInterruptedExceptionTest.java b/src/test/java/org/apache/commons/lang3/exception/UncheckedInterruptedExceptionTest.java
index 17243cc..e0cb162 100644
--- a/src/test/java/org/apache/commons/lang3/exception/UncheckedInterruptedExceptionTest.java
+++ b/src/test/java/org/apache/commons/lang3/exception/UncheckedInterruptedExceptionTest.java
@@ -27,7 +27,7 @@
 
     @Test
     public void testConstructWithCause() {
-        Exception e = new Exception();
+        final Exception e = new Exception();
         assertSame(e, new UncheckedInterruptedException(e).getCause());
     }
 

src/test/java/org/apache/commons/lang3/function/BooleanConsumerTest.java

diff --git a/src/test/java/org/apache/commons/lang3/function/BooleanConsumerTest.java b/src/test/java/org/apache/commons/lang3/function/BooleanConsumerTest.java
index 247a07b..626dcb3 100644
--- a/src/test/java/org/apache/commons/lang3/function/BooleanConsumerTest.java
+++ b/src/test/java/org/apache/commons/lang3/function/BooleanConsumerTest.java
@@ -66,11 +66,8 @@
         assertFalse(aBool2.get());
 
         // Check order
-        final BooleanConsumer bad = new BooleanConsumer() {
-            @Override
-            public void accept(boolean value) {
-                throw new IllegalStateException();
-            }
+        final BooleanConsumer bad = value -> {
+            throw new IllegalStateException();
         };
         final BooleanConsumer badComposite = bad.andThen(aBool2::lazySet);