commit 4255d58ef5cd74346b6c4b6a49b90ab9aae7acaf
author Bruno P. Kinoshita <kinow@users.noreply.github.com> Mon Jan 20 10:16:02 2020 +1300
committer Bruno P. Kinoshita <kinow@users.noreply.github.com> Mon Jan 20 10:16:02 2020 +1300
tree cf4a4b04bac8deb86193245e429982b58d919a7e
parent 4135eb997f3354e6762a892f71cc9818c7d6b74e

[IMAGING-248]: fix checkstyle issues

src/main/java/org/apache/commons/imaging/formats/icns/IcnsDecoder.java

diff --git a/src/main/java/org/apache/commons/imaging/formats/icns/IcnsDecoder.java b/src/main/java/org/apache/commons/imaging/formats/icns/IcnsDecoder.java
index 7cf63f2..c68b544 100644
--- a/src/main/java/org/apache/commons/imaging/formats/icns/IcnsDecoder.java
+++ b/src/main/java/org/apache/commons/imaging/formats/icns/IcnsDecoder.java
@@ -197,7 +197,7 @@
         for (int i = 0; i < icnsElements.length; i++) {
             BufferedImage image = decodeImage(icnsElements, i);
             if (image != null) {
-            	result.add(image);
+                result.add(image);
             }
         }
         return result;
@@ -230,8 +230,7 @@
                 if (imageType.getWidth() <= 32) {
                     try {
                         image = decodeImageImpl(imageType, imageElement, icnsElements);
-                    }
-                    catch (Exception ignored) { }
+                    } catch (Exception ignored) { }
                 }
                 if (image == null) {
                     image = new BufferedImage(imageType.getWidth(), imageType.getHeight(), BufferedImage.TYPE_INT_ARGB);
@@ -254,12 +253,10 @@
                 imageData = Rle24Compression.decompress(
                   imageType.getWidth(), imageType.getHeight(),
                   imageElement.data);
-            }
-            else {
+            } else {
                 throw new ImageReadException("Short image data but not a 32 bit compressed type");
             }
-        }
-        else {
+        } else {
             imageData = imageElement.data;
         }
 
@@ -287,8 +284,7 @@
         if (imageType.hasMask()) {
             maskType = imageType;
             maskElement = imageElement;
-        }
-        else {
+        } else {
             maskType = IcnsType.find8BPPMaskType(imageType);
             if (maskType != null) {
                 for (final IcnsElement icnsElement : icnsElements) {
@@ -314,11 +310,9 @@
         if (maskElement != null) {
             if (maskType.getBitsPerPixel() == 1) {
                 apply1BPPMask(maskElement.data, imageBuilder);
-            }
-            else if (maskType.getBitsPerPixel() == 8) {
+            } else if (maskType.getBitsPerPixel() == 8) {
                 apply8BPPMask(maskElement.data, imageBuilder);
-            }
-            else {
+            } else {
                 throw new ImageReadException("Unsupported mask bit depth " + maskType.getBitsPerPixel());
             }
         }

src/main/java/org/apache/commons/imaging/formats/icns/IcnsImageParser.java

diff --git a/src/main/java/org/apache/commons/imaging/formats/icns/IcnsImageParser.java b/src/main/java/org/apache/commons/imaging/formats/icns/IcnsImageParser.java
index 16498ed..0851774 100644
--- a/src/main/java/org/apache/commons/imaging/formats/icns/IcnsImageParser.java
+++ b/src/main/java/org/apache/commons/imaging/formats/icns/IcnsImageParser.java
@@ -193,7 +193,7 @@
         final int elementSize = read4Bytes("ElementSize", is, "Not a valid ICNS file", getByteOrder());
         if (elementSize > remainingSize) {
             throw new IOException(String.format("Corrupted ICNS file: element size %d is greater than "
-            		+ "remaining size %d", elementSize, remainingSize));
+                    + "remaining size %d", elementSize, remainingSize));
         }
         final byte[] data = readBytes("Data", is, elementSize - 8, "Not a valid ICNS file");