Merge pull request #129 from arturobernalg/feature/minor_improvement
Minor Improvement:
diff --git a/commons-geometry-core/src/main/java/org/apache/commons/geometry/core/partitioning/bsp/AbstractBSPTree.java b/commons-geometry-core/src/main/java/org/apache/commons/geometry/core/partitioning/bsp/AbstractBSPTree.java
index f7b33ea..fc3c37b 100644
--- a/commons-geometry-core/src/main/java/org/apache/commons/geometry/core/partitioning/bsp/AbstractBSPTree.java
+++ b/commons-geometry-core/src/main/java/org/apache/commons/geometry/core/partitioning/bsp/AbstractBSPTree.java
@@ -200,7 +200,7 @@
.append(count())
.append(", height= ")
.append(height())
- .append("]")
+ .append(']')
.toString();
}
diff --git a/commons-geometry-core/src/test/java/org/apache/commons/geometry/core/internal/IteratorTransformTest.java b/commons-geometry-core/src/test/java/org/apache/commons/geometry/core/internal/IteratorTransformTest.java
index 64f1189..97d9a30 100644
--- a/commons-geometry-core/src/test/java/org/apache/commons/geometry/core/internal/IteratorTransformTest.java
+++ b/commons-geometry-core/src/test/java/org/apache/commons/geometry/core/internal/IteratorTransformTest.java
@@ -72,17 +72,17 @@
// filter out odd integers
final int value = input;
if (value % 2 == 0) {
- final char[] chars = (value + "").toCharArray();
+ final char[] chars = (Integer.toString(value)).toCharArray();
if (chars.length > 1) {
final List<String> strs = new ArrayList<>();
for (final char ch : chars) {
- strs.add(ch + "");
+ strs.add(String.valueOf(ch));
}
addAllOutput(strs);
} else if (chars.length == 1) {
- addOutput(chars[0] + "");
+ addOutput(String.valueOf(chars[0]));
}
}
}
diff --git a/commons-geometry-core/src/test/java/org/apache/commons/geometry/core/partitioning/bsp/MergeChecker.java b/commons-geometry-core/src/test/java/org/apache/commons/geometry/core/partitioning/bsp/MergeChecker.java
index cf37fa2..35afa7d 100644
--- a/commons-geometry-core/src/test/java/org/apache/commons/geometry/core/partitioning/bsp/MergeChecker.java
+++ b/commons-geometry-core/src/test/java/org/apache/commons/geometry/core/partitioning/bsp/MergeChecker.java
@@ -57,10 +57,10 @@
private int expectedCount = -1;
/** The expected full state of the merged tree */
- private boolean expectedFull = false;
+ private boolean expectedFull;
/** The expected empty state of the merged tree */
- private boolean expectedEmpty = false;
+ private boolean expectedEmpty;
/** Points expected to lie in the inside of the region */
private final List<TestPoint2D> insidePoints = new ArrayList<>();
diff --git a/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/testio/TestOBJWriter.java b/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/testio/TestOBJWriter.java
index b39dad4..13bd9ee 100644
--- a/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/testio/TestOBJWriter.java
+++ b/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/testio/TestOBJWriter.java
@@ -59,7 +59,7 @@
private DecimalFormat decimalFormat;
/** Number of vertices written to the output. */
- private int vertexCount = 0;
+ private int vertexCount;
/** Create a new instance for writing to the given file.
* @param file file to write to
diff --git a/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/oned/Transform1S.java b/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/oned/Transform1S.java
index 269c111..1630827 100644
--- a/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/oned/Transform1S.java
+++ b/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/oned/Transform1S.java
@@ -182,7 +182,7 @@
.append(isNegation())
.append(", rotate= ")
.append(getRotation())
- .append("]");
+ .append(']');
return sb.toString();
}
diff --git a/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/twod/GreatArc.java b/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/twod/GreatArc.java
index 8a82e19..8d449e8 100644
--- a/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/twod/GreatArc.java
+++ b/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/twod/GreatArc.java
@@ -175,8 +175,7 @@
@Override
public String toString() {
final StringBuilder sb = new StringBuilder();
- sb.append(this.getClass().getSimpleName())
- .append("[");
+ sb.append(this.getClass().getSimpleName()).append('[');
if (isFull()) {
sb.append("full= true, circle= ")
diff --git a/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/twod/GreatArcPath.java b/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/twod/GreatArcPath.java
index cff1995..681bc42 100644
--- a/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/twod/GreatArcPath.java
+++ b/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/twod/GreatArcPath.java
@@ -187,7 +187,7 @@
.append(getVertices());
}
- sb.append("]");
+ sb.append(']');
return sb.toString();
}
diff --git a/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/twod/Transform2S.java b/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/twod/Transform2S.java
index 8ab514d..024c095 100644
--- a/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/twod/Transform2S.java
+++ b/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/twod/Transform2S.java
@@ -172,7 +172,7 @@
sb.append(this.getClass().getSimpleName())
.append("[euclideanTransform= ")
.append(getEuclideanTransform())
- .append("]");
+ .append(']');
return sb.toString();
}
