commit 97f0092b16e8a17bc016f21a8aafab74de9a89bb
author Jochen Wiedmann (jwi) <jochen.wiedmann@softwareag.com> Sat Feb 23 17:23:59 2019 +0100
committer Jochen Wiedmann (jwi) <jochen.wiedmann@softwareag.com> Sat Feb 23 17:24:28 2019 +0100
tree ff6ca57fd70e63c624afc67df1fa182625529cfa
parent 2cf7d09fefb17c59e5a776fd6850aebdf41046b2

PR: FILEUPLOAD-293 Attempt to reproduce the issue.

src/test/java/org/apache/commons/fileupload2/DiskFileUploadTest.java

diff --git a/src/test/java/org/apache/commons/fileupload2/DiskFileUploadTest.java b/src/test/java/org/apache/commons/fileupload2/DiskFileUploadTest.java
index 0435d9c..a9fcdec 100644
--- a/src/test/java/org/apache/commons/fileupload2/DiskFileUploadTest.java
+++ b/src/test/java/org/apache/commons/fileupload2/DiskFileUploadTest.java
@@ -16,12 +16,16 @@
  */
 package org.apache.commons.fileupload2;
 
-import static org.junit.Assert.fail;
+import static org.junit.Assert.*;
+
+import java.io.File;
+import java.util.List;
 
 import javax.servlet.http.HttpServletRequest;
 
 import org.apache.commons.fileupload2.DiskFileUpload;
 import org.apache.commons.fileupload2.FileUploadException;
+import org.apache.commons.fileupload2.disk.DiskFileItem;
 import org.junit.Before;
 import org.junit.Test;
 
@@ -66,4 +70,35 @@
         }
     }
 
+    /** Proposed test for FILEUPLOAD-293. As of yet, doesn't reproduce the problem.
+     */
+    @Test
+    public void testMoveFile() throws Exception {
+        DiskFileUpload myUpload = new DiskFileUpload();
+        myUpload.setSizeThreshold(0);
+    	final String content = 
+                "-----1234\r\n" +
+                "Content-Disposition: form-data; name=\"file\";"
+                		+ "filename=\"foo.tab\"\r\n" +
+                "Content-Type: text/whatever\r\n" +
+                "\r\n" +
+                "This is the content of the file\n" +
+                "\r\n" +
+                "-----1234--\r\n";
+    	final byte[] contentBytes = content.getBytes("US-ASCII");
+        final HttpServletRequest request = new MockHttpServletRequest(contentBytes, Constants.CONTENT_TYPE);
+        final List<FileItem> items = myUpload.parseRequest(request);
+        assertNotNull(items);
+        assertFalse(items.isEmpty());
+        final DiskFileItem dfi = (DiskFileItem) items.get(0);
+        final File out = new File("target/unit-tests/DiskFileUpload/out.file");
+        if (out.isFile()) {
+        	out.delete();
+        }
+        final File outDir = out.getParentFile();
+        if (!outDir.isDirectory()) {
+        	outDir.mkdirs();
+        }
+        dfi.write(out);
+    }
 }