FILEUPLOAD-244 DiskFileItem.readObject fails to close FileInputStream
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/fileupload/trunk@1568691 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index f2c3815..794d7c4 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -45,6 +45,7 @@
<body>
<release version="1.4" date="TBA" description=
"TBA">
+ <action issue="FILEUPLOAD-244" dev="sebb" type="fix">DiskFileItem.readObject fails to close FileInputStream</action>
<action issue="FILEUPLOAD-246" dev="sebb" type="update">FileUpload should use IOUtils.closeQuietly where relevant</action>
<action issue="FILEUPLOAD-245" dev="sebb" type="fix">DiskFileItem.get() may not fully read the data</action>
<action issue="FILEUPLOAD-243" dev="sebb" type="update" due-to="Ville Skyttä">Make some MultipartStream private fields final</action>
diff --git a/src/main/java/org/apache/commons/fileupload/disk/DiskFileItem.java b/src/main/java/org/apache/commons/fileupload/disk/DiskFileItem.java
index f56ebd4..0eb56b4 100644
--- a/src/main/java/org/apache/commons/fileupload/disk/DiskFileItem.java
+++ b/src/main/java/org/apache/commons/fileupload/disk/DiskFileItem.java
@@ -665,6 +665,7 @@
} else {
FileInputStream input = new FileInputStream(dfosFile);
IOUtils.copy(input, output);
+ input.close();
dfosFile.delete();
dfosFile = null;
}
