commit bbff53160f71735df6394c24989926d31abec1a4
author Gary Gregory <garydgregory@gmail.com> Sun Jan 17 10:10:56 2021 -0500
committer Gary Gregory <garydgregory@gmail.com> Sun Jan 17 10:10:56 2021 -0500
tree fc187ad5ac6eac57da508a444fde7387d2bc59be
parent 611118338bd16ea706cc126beacf2ff0e94f3188

Use isEmpty().

src/test/java/org/apache/commons/exec/DefaultExecutorTest.java

diff --git a/src/test/java/org/apache/commons/exec/DefaultExecutorTest.java b/src/test/java/org/apache/commons/exec/DefaultExecutorTest.java
index 896de1b..7ebbece 100644
--- a/src/test/java/org/apache/commons/exec/DefaultExecutorTest.java
+++ b/src/test/java/org/apache/commons/exec/DefaultExecutorTest.java
@@ -675,7 +675,7 @@
     public void testEnvironmentVariables() throws Exception {
         exec.execute(new CommandLine(environmentSript));
         final String environment = baos.toString().trim();
-        assertTrue("Found no environment variables", environment.length() > 0);
+        assertFalse("Found no environment variables", environment.isEmpty());
         assertFalse(environment.indexOf("NEW_VAR") >= 0);
     }
 

src/test/java/org/apache/commons/exec/environment/EnvironmentUtilsTest.java

diff --git a/src/test/java/org/apache/commons/exec/environment/EnvironmentUtilsTest.java b/src/test/java/org/apache/commons/exec/environment/EnvironmentUtilsTest.java
index 39c676c..1b3a423 100644
--- a/src/test/java/org/apache/commons/exec/environment/EnvironmentUtilsTest.java
+++ b/src/test/java/org/apache/commons/exec/environment/EnvironmentUtilsTest.java
@@ -76,7 +76,7 @@
         final String[] envArgs = EnvironmentUtils.toStrings(procEnvironment);
         for (int i=0; i<envArgs.length; i++) {
             assertNotNull("Entry "+i+" should not be null",envArgs[i]);
-            assertTrue("Entry "+i+" should not be empty",envArgs[i].length() > 0);
+            assertFalse("Entry "+i+" should not be empty",envArgs[i].isEmpty());
             // System.out.println(envArgs[i]);
         }
     }