commit 4c10370ac86c1bf78548b9f39e8158a21d6796c9
author Gary Gregory <garydgregory@gmail.com> Fri Mar 05 13:59:59 2021 -0500
committer Gary Gregory <garydgregory@gmail.com> Fri Mar 05 13:59:59 2021 -0500
tree d0adeacdd23258dbb1d63c1a5e149ad551701cea
parent cdd7216cf3fd3c0310d428d5b996d1435a9f264b

No need to nest in else.

src/main/java/org/apache/commons/mail/Email.java

diff --git a/src/main/java/org/apache/commons/mail/Email.java b/src/main/java/org/apache/commons/mail/Email.java
index cbc23a1..16a8ac2 100644
--- a/src/main/java/org/apache/commons/mail/Email.java
+++ b/src/main/java/org/apache/commons/mail/Email.java
@@ -1558,7 +1558,7 @@
         {
             return this.session.getProperty(EmailConstants.MAIL_HOST);
         }
-        else if (EmailUtils.isNotEmpty(this.hostName))
+        if (EmailUtils.isNotEmpty(this.hostName))
         {
             return this.hostName;
         }
@@ -1576,7 +1576,7 @@
         {
             return this.session.getProperty(EmailConstants.MAIL_PORT);
         }
-        else if (EmailUtils.isNotEmpty(this.smtpPort))
+        if (EmailUtils.isNotEmpty(this.smtpPort))
         {
             return this.smtpPort;
         }
@@ -1746,7 +1746,7 @@
         {
             return this.session.getProperty(EmailConstants.MAIL_SMTP_SOCKET_FACTORY_PORT);
         }
-        else if (EmailUtils.isNotEmpty(this.sslSmtpPort))
+        if (EmailUtils.isNotEmpty(this.sslSmtpPort))
         {
             return this.sslSmtpPort;
         }