| commit | 3262ac78e7cd333d85ce6d5c3509d48af45070a8 | [log] [tgz] |
|---|---|---|
| author | Gary D. Gregory <ggregory@apache.org> | Sun Jul 26 17:44:44 2015 +0000 |
| committer | Gary D. Gregory <ggregory@apache.org> | Sun Jul 26 17:44:44 2015 +0000 |
| tree | 35f50b5ef616065a6416452107db705e20d5840e | |
| parent | 78b9fdfc1e9b87257666d58bebb9d2570b26a77e [diff] |
Add final modifier where possible. git-svn-id: https://svn.apache.org/repos/asf/commons/proper/email/trunk@1692734 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/src/main/java/org/apache/commons/mail/HtmlEmail.java b/src/main/java/org/apache/commons/mail/HtmlEmail.java index 01e42e7..fddbe74 100644 --- a/src/main/java/org/apache/commons/mail/HtmlEmail.java +++ b/src/main/java/org/apache/commons/mail/HtmlEmail.java
@@ -471,7 +471,7 @@ try { // URL encode the cid according to RFC 2392 - String encodedCid = EmailUtils.encodeUrl(cid); + final String encodedCid = EmailUtils.encodeUrl(cid); mbp.setDataHandler(new DataHandler(dataSource)); mbp.setFileName(name);
diff --git a/src/test/java/org/apache/commons/mail/ImageHtmlEmailTest.java b/src/test/java/org/apache/commons/mail/ImageHtmlEmailTest.java index e8f85fc..4e4f932 100644 --- a/src/test/java/org/apache/commons/mail/ImageHtmlEmailTest.java +++ b/src/test/java/org/apache/commons/mail/ImageHtmlEmailTest.java
@@ -498,8 +498,8 @@ } @Override - public DataSource resolve(String resourceLocation, boolean isLenient) throws IOException { - javax.mail.util.ByteArrayDataSource ds = + public DataSource resolve(final String resourceLocation, final boolean isLenient) throws IOException { + final javax.mail.util.ByteArrayDataSource ds = (javax.mail.util.ByteArrayDataSource) super.resolve(resourceLocation, isLenient); ds.setName(null); return ds;
diff --git a/src/test/java/org/apache/commons/mail/resolver/AbstractDataSourceResolverTest.java b/src/test/java/org/apache/commons/mail/resolver/AbstractDataSourceResolverTest.java index 0151613..7466b0b 100644 --- a/src/test/java/org/apache/commons/mail/resolver/AbstractDataSourceResolverTest.java +++ b/src/test/java/org/apache/commons/mail/resolver/AbstractDataSourceResolverTest.java
@@ -31,7 +31,7 @@ { if(dataSource != null) { - InputStream is = dataSource.getInputStream(); + final InputStream is = dataSource.getInputStream(); try { return IOUtils.toByteArray(is); } finally {