commit 613074455600ca29c046f4243b8864c69e52fca6
author Simone Tripodi <simonetripodi@apache.org> Fri Oct 21 21:59:53 2011 +0000
committer Simone Tripodi <simonetripodi@apache.org> Fri Oct 21 21:59:53 2011 +0000
tree d57461009bc0728102a9cf1576aa6224c6aa4f5b
parent c83f5919085272101ef8ba7d53088b53f2dd701f

fixed PMD violation: These nested if statements could be combined

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/digester/trunk@1187572 13f79535-47bb-0310-9956-ffa450edef68

src/main/java/org/apache/commons/digester3/xmlrules/FromXmlRulesModule.java

diff --git a/src/main/java/org/apache/commons/digester3/xmlrules/FromXmlRulesModule.java b/src/main/java/org/apache/commons/digester3/xmlrules/FromXmlRulesModule.java
index de18ad5..ee090ee 100644
--- a/src/main/java/org/apache/commons/digester3/xmlrules/FromXmlRulesModule.java
+++ b/src/main/java/org/apache/commons/digester3/xmlrules/FromXmlRulesModule.java
@@ -103,7 +103,7 @@
     }
 
     /**
-     * 
+     *
      */
     protected abstract void loadRules();
 
@@ -122,12 +122,9 @@
         this.inputSource.add( inputSource );
 
         String systemId = inputSource.getSystemId();
-        if ( systemId != null )
+        if ( systemId != null && !systemIds.add( systemId ) )
         {
-            if ( !systemIds.add( systemId ) )
-            {
-                addError( "XML rules file '%s' already bound", systemId );
-            }
+            addError( "XML rules file '%s' already bound", systemId );
         }
     }