commit 06e772d3cbcb18d4a7ed2f1dcaa8c83b6001fa80
author Simone Tripodi <simonetripodi@apache.org> Fri Jul 01 21:19:13 2011 +0000
committer Simone Tripodi <simonetripodi@apache.org> Fri Jul 01 21:19:13 2011 +0000
tree 5295a418ade65fd7dcaff811572636690debb8ec
parent 2f35921900d56288b2ac2825e57e7403efee2d2c

no reason to throw an hard to interpret NPE late, better raising an exception as soon as classes cannot be load, much easier to debug - rule init and rule invocation could happen in different times

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/digester/trunk@1142095 13f79535-47bb-0310-9956-ffa450edef68

src/main/java/org/apache/commons/digester3/CallMethodRule.java

diff --git a/src/main/java/org/apache/commons/digester3/CallMethodRule.java b/src/main/java/org/apache/commons/digester3/CallMethodRule.java
index 3c7cfff..a480825 100644
--- a/src/main/java/org/apache/commons/digester3/CallMethodRule.java
+++ b/src/main/java/org/apache/commons/digester3/CallMethodRule.java
@@ -342,10 +342,11 @@
                 }
                 catch ( ClassNotFoundException e )
                 {
+                    String errorMessage = format( "[CallMethodRule] Cannot load class %s at position %s",
+                                                  this.paramClassNames[i], i );
                     // use the digester log
-                    digester.getLogger().error( format( "[CallMethodRule] Cannot load class %s",
-                                                        this.paramClassNames[i] ), e );
-                    this.paramTypes[i] = null; // Will cause NPE later
+                    digester.getLogger().error( errorMessage, e );
+                    throw new RuntimeException( errorMessage, e );
                 }
             }
         }