| /* |
| * Licensed to the Apache Software Foundation (ASF) under one or more |
| * contributor license agreements. See the NOTICE file distributed with |
| * this work for additional information regarding copyright ownership. |
| * The ASF licenses this file to You under the Apache License, Version 2.0 |
| * (the "License"); you may not use this file except in compliance with |
| * the License. You may obtain a copy of the License at |
| * |
| * http://www.apache.org/licenses/LICENSE-2.0 |
| * |
| * Unless required by applicable law or agreed to in writing, software |
| * distributed under the License is distributed on an "AS IS" BASIS, |
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| * See the License for the specific language governing permissions and |
| * limitations under the License. |
| */ |
| |
| package org.apache.commons.dbcp2; |
| |
| import static org.junit.Assert.assertNotSame; |
| import static org.junit.Assert.assertSame; |
| import static org.junit.Assert.assertTrue; |
| import static org.junit.Assert.fail; |
| |
| import java.sql.Connection; |
| import java.sql.DriverManager; |
| import java.sql.PreparedStatement; |
| import java.sql.Statement; |
| import java.sql.SQLException; |
| |
| import javax.management.ObjectName; |
| import javax.sql.DataSource; |
| |
| import org.apache.commons.pool2.ObjectPool; |
| import org.apache.commons.pool2.impl.GenericObjectPool; |
| import org.apache.commons.pool2.impl.GenericObjectPoolConfig; |
| import org.junit.Assert; |
| import org.junit.Test; |
| |
| /** |
| * TestSuite for BasicDataSource with prepared statement pooling enabled |
| */ |
| public class TestPStmtPooling { |
| |
| @Test |
| public void testStmtPool() throws Exception { |
| final DataSource ds = createPDS(); |
| try (Connection conn = ds.getConnection()) { |
| final Statement stmt1 = conn.prepareStatement("select 1 from dual"); |
| final Statement ustmt1 = ((DelegatingStatement) stmt1).getInnermostDelegate(); |
| stmt1.close(); |
| final Statement stmt2 = conn.prepareStatement("select 1 from dual"); |
| final Statement ustmt2 = ((DelegatingStatement) stmt2).getInnermostDelegate(); |
| stmt2.close(); |
| assertSame(ustmt1, ustmt2); |
| } |
| } |
| |
| /** |
| * Verifies that executing close() on an already closed DelegatingStatement |
| * that wraps a PoolablePreparedStatement does not "re-close" the PPS |
| * (which could be in use by another client - see DBCP-414). |
| */ |
| @Test |
| public void testMultipleClose() throws Exception { |
| final DataSource ds = createPDS(); |
| PreparedStatement stmt1 = null; |
| final Connection conn = ds.getConnection(); |
| stmt1 = conn.prepareStatement("select 1 from dual"); |
| final PoolablePreparedStatement<?> pps1 = getPoolablePreparedStatement(stmt1); |
| conn.close(); |
| assertTrue(stmt1.isClosed()); // Closing conn should close stmt |
| stmt1.close(); // Should already be closed - no-op |
| assertTrue(stmt1.isClosed()); |
| final Connection conn2 = ds.getConnection(); |
| final PreparedStatement stmt2 = conn2.prepareStatement("select 1 from dual"); |
| // Confirm stmt2 now wraps the same PPS wrapped by stmt1 |
| Assert.assertSame(pps1, getPoolablePreparedStatement(stmt2)); |
| stmt1.close(); // close should not cascade to PPS that stmt1 used to wrap |
| assertTrue(!stmt2.isClosed()); |
| stmt2.executeQuery(); // wrapped PPS needs to work here - pre DBCP-414 fix this throws |
| conn2.close(); |
| assertTrue(stmt1.isClosed()); |
| assertTrue(stmt2.isClosed()); |
| } |
| |
| |
| private PoolablePreparedStatement<?> getPoolablePreparedStatement(Statement s) { |
| |
| while (s != null) { |
| if (s instanceof PoolablePreparedStatement) { |
| return (PoolablePreparedStatement<?>) s; |
| } |
| if (s instanceof DelegatingPreparedStatement) { |
| s = ((DelegatingPreparedStatement) s).getDelegate(); |
| } else { |
| return null; |
| } |
| } |
| return null; |
| } |
| |
| |
| private DataSource createPDS() throws Exception { |
| DriverManager.registerDriver(new TesterDriver()); |
| final ConnectionFactory connFactory = new DriverManagerConnectionFactory( |
| "jdbc:apache:commons:testdriver","u1","p1"); |
| |
| final PoolableConnectionFactory pcf = |
| new PoolableConnectionFactory(connFactory, null); |
| pcf.setPoolStatements(true); |
| pcf.setDefaultReadOnly(Boolean.FALSE); |
| pcf.setDefaultAutoCommit(Boolean.TRUE); |
| final ObjectPool<PoolableConnection> connPool = new GenericObjectPool<>(pcf); |
| pcf.setPool(connPool); |
| |
| return new PoolingDataSource<>(connPool); |
| |
| } |
| |
| @Test |
| public void testCallableStatementPooling() throws Exception { |
| DriverManager.registerDriver(new TesterDriver()); |
| final ConnectionFactory connFactory = new DriverManagerConnectionFactory( |
| "jdbc:apache:commons:testdriver","u1","p1"); |
| |
| final ObjectName oName = new ObjectName("UnitTests:DataSource=test"); |
| final PoolableConnectionFactory pcf = |
| new PoolableConnectionFactory(connFactory, oName); |
| pcf.setPoolStatements(true); |
| pcf.setDefaultReadOnly(Boolean.FALSE); |
| pcf.setDefaultAutoCommit(Boolean.TRUE); |
| |
| final GenericObjectPoolConfig config = new GenericObjectPoolConfig(); |
| config.setJmxNameBase("UnitTests:DataSource=test,connectionpool=connections"); |
| config.setJmxNamePrefix(""); |
| final ObjectPool<PoolableConnection> connPool = |
| new GenericObjectPool<>(pcf, config); |
| pcf.setPool(connPool); |
| |
| final PoolingDataSource<?> ds = new PoolingDataSource<>(connPool); |
| |
| try (Connection conn = ds.getConnection()) { |
| final Statement stmt1 = conn.prepareStatement("select 1 from dual"); |
| final Statement ustmt1 = ((DelegatingStatement) stmt1).getInnermostDelegate(); |
| final Statement cstmt1 = conn.prepareCall("{call home}"); |
| final Statement ucstmt1 = ((DelegatingStatement) cstmt1).getInnermostDelegate(); |
| stmt1.close(); // Return to pool |
| cstmt1.close(); // "" |
| final Statement stmt2 = conn.prepareStatement("select 1 from dual"); // Check out from pool |
| final Statement ustmt2 = ((DelegatingStatement) stmt2).getInnermostDelegate(); |
| final Statement cstmt2 = conn.prepareCall("{call home}"); |
| final Statement ucstmt2 = ((DelegatingStatement) cstmt2).getInnermostDelegate(); |
| stmt2.close(); // Return to pool |
| cstmt2.close(); // "" |
| assertSame(ustmt1, ustmt2); |
| assertSame(ucstmt1, ucstmt2); |
| // Verify key distinguishes Callable from Prepared Statements in the pool |
| final Statement stmt3 = conn.prepareCall("select 1 from dual"); |
| final Statement ustmt3 = ((DelegatingStatement) stmt3).getInnermostDelegate(); |
| stmt3.close(); |
| assertNotSame(ustmt1, ustmt3); |
| assertNotSame(ustmt3, ucstmt1); |
| } |
| ds.close(); |
| } |
| |
| @Test |
| public void testClosePool() throws Exception { |
| DriverManager.registerDriver(new TesterDriver()); |
| final ConnectionFactory connFactory = new DriverManagerConnectionFactory( |
| "jdbc:apache:commons:testdriver","u1","p1"); |
| |
| final PoolableConnectionFactory pcf = |
| new PoolableConnectionFactory(connFactory, null); |
| pcf.setPoolStatements(true); |
| pcf.setDefaultReadOnly(Boolean.FALSE); |
| pcf.setDefaultAutoCommit(Boolean.TRUE); |
| |
| final ObjectPool<PoolableConnection> connPool = new GenericObjectPool<>(pcf); |
| pcf.setPool(connPool); |
| |
| final PoolingDataSource<?> ds = new PoolingDataSource<>(connPool); |
| ((PoolingDataSource<?>) ds).setAccessToUnderlyingConnectionAllowed(true); |
| |
| final Connection conn = ds.getConnection(); |
| try (Statement s = conn.prepareStatement("select 1 from dual")) {} |
| |
| final Connection poolableConnection = ((DelegatingConnection<?>) conn).getDelegate(); |
| final Connection poolingConnection = |
| ((DelegatingConnection<?>) poolableConnection).getDelegate(); |
| poolingConnection.close(); |
| try (PreparedStatement ps = conn.prepareStatement("select 1 from dual")) { |
| fail("Expecting SQLException"); |
| } catch (final SQLException ex) { |
| assertTrue(ex.getMessage().endsWith("invalid PoolingConnection.")); |
| } |
| ds.close(); |
| } |
| |
| @Test |
| public void testBatchUpdate() throws Exception { |
| DriverManager.registerDriver(new TesterDriver()); |
| final ConnectionFactory connFactory = new DriverManagerConnectionFactory( |
| "jdbc:apache:commons:testdriver","u1","p1"); |
| |
| final PoolableConnectionFactory pcf = |
| new PoolableConnectionFactory(connFactory, null); |
| pcf.setPoolStatements(true); |
| pcf.setDefaultReadOnly(Boolean.FALSE); |
| pcf.setDefaultAutoCommit(Boolean.TRUE); |
| final ObjectPool<PoolableConnection> connPool = new GenericObjectPool<>(pcf); |
| pcf.setPool(connPool); |
| |
| final PoolingDataSource<?> ds = new PoolingDataSource<>(connPool); |
| |
| final Connection conn = ds.getConnection(); |
| final PreparedStatement ps = conn.prepareStatement("select 1 from dual"); |
| final Statement inner = ((DelegatingPreparedStatement) ps).getInnermostDelegate(); |
| // Check DBCP-372 |
| ps.addBatch(); |
| ps.close(); |
| conn.close(); |
| Assert.assertFalse(inner.isClosed()); |
| ds.close(); |
| } |
| } |