Define and use constants for empty arrays.
diff --git a/src/main/java/org/apache/commons/dbcp2/PoolingDriver.java b/src/main/java/org/apache/commons/dbcp2/PoolingDriver.java
index 8e88664..316c868 100644
--- a/src/main/java/org/apache/commons/dbcp2/PoolingDriver.java
+++ b/src/main/java/org/apache/commons/dbcp2/PoolingDriver.java
@@ -36,6 +36,8 @@
*/
public class PoolingDriver implements Driver {
+ private static final DriverPropertyInfo[] EMPTY_DRIVER_PROPERTY_INFO_ARRAY = new DriverPropertyInfo[0];
+
/* Register myself with the {@link DriverManager}. */
static {
try {
@@ -209,7 +211,7 @@
@Override
public DriverPropertyInfo[] getPropertyInfo(final String url, final Properties info) {
- return new DriverPropertyInfo[0];
+ return EMPTY_DRIVER_PROPERTY_INFO_ARRAY;
}
/** My URL prefix */
diff --git a/src/main/java/org/apache/commons/dbcp2/managed/LocalXAConnectionFactory.java b/src/main/java/org/apache/commons/dbcp2/managed/LocalXAConnectionFactory.java
index 996a4e7..44faba8 100644
--- a/src/main/java/org/apache/commons/dbcp2/managed/LocalXAConnectionFactory.java
+++ b/src/main/java/org/apache/commons/dbcp2/managed/LocalXAConnectionFactory.java
@@ -50,6 +50,7 @@
* @since 2.0
*/
protected static class LocalXAResource implements XAResource {
+ private static final Xid[] EMPTY_XID_ARRAY = new Xid[0];
private final Connection connection;
private Xid currentXid; // @GuardedBy("this")
private boolean originalAutoCommit; // @GuardedBy("this")
@@ -207,7 +208,7 @@
*/
@Override
public Xid[] recover(final int flag) {
- return new Xid[0];
+ return EMPTY_XID_ARRAY;
}
/**
