commit d1a6b10bbe0a8d234160aa70935872525122802b
author Stefan Bodewig <bodewig@apache.org> Mon Sep 02 17:41:53 2019 +0200
committer Stefan Bodewig <bodewig@apache.org> Mon Sep 02 17:41:53 2019 +0200
tree fd4784908abe0c820b6e0068accba6f3c5a6fda7
parent 3a0ac2ca83436ebe59cbe91e241f6a245125f0b1

COMPRESS-450 headerErrorOccurred need to be written somewhere, avoid NPE

src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveInputStream.java

diff --git a/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveInputStream.java b/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveInputStream.java
index d5d9ca0..4751ce5 100644
--- a/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveInputStream.java
+++ b/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveInputStream.java
@@ -286,7 +286,7 @@
         byte[] headerBuf = getRecord();
 
         if (headerErrorOccurred) {
-            do {
+            while (headerBuf != null) {
                 try {
                     if (TarUtils.verifyCheckSum(headerBuf)) {
                         break;
@@ -295,8 +295,10 @@
                     // next record is not a valid tar header either
                 }
                 entryOffset += recordSize;
-            } while ((headerBuf = getRecord()) != null);
+                headerBuf = getRecord();
+            }
         }
+        headerErrorOccurred = false;
 
         if (headerBuf == null) {
             /* hit EOF */
@@ -307,6 +309,7 @@
         try {
             currEntry = new TarArchiveEntry(headerBuf, zipEncoding);
         } catch (final IllegalArgumentException e) {
+            headerErrorOccurred = true;
             throw new InvalidTarHeaderException(e);
         }