commit 2a1fc6b85977f9aa34c4a26234b68f3e5edb8f72
author Gary Gregory <garydgregory@gmail.com> Sat Jan 02 18:23:18 2021 -0500
committer Gary Gregory <garydgregory@gmail.com> Sat Jan 02 18:23:18 2021 -0500
tree f13d16e8e28f146dbf8cb3a300db3b38efe942b9
parent 00ea5eeb9105b59674cc3cf6c5478e96ee6c1e4e

Simplify array cloning.

src/main/java/org/apache/commons/codec/binary/Base32.java

diff --git a/src/main/java/org/apache/commons/codec/binary/Base32.java b/src/main/java/org/apache/commons/codec/binary/Base32.java
index 0b165c1..592b4ed 100644
--- a/src/main/java/org/apache/commons/codec/binary/Base32.java
+++ b/src/main/java/org/apache/commons/codec/binary/Base32.java
@@ -334,8 +334,7 @@
                 throw new IllegalArgumentException("lineSeparator must not contain Base32 characters: [" + sep + "]");
             }
             this.encodeSize = BYTES_PER_ENCODED_BLOCK + lineSeparator.length;
-            this.lineSeparator = new byte[lineSeparator.length];
-            System.arraycopy(lineSeparator, 0, this.lineSeparator, 0, lineSeparator.length);
+            this.lineSeparator = lineSeparator.clone();
         } else {
             this.encodeSize = BYTES_PER_ENCODED_BLOCK;
             this.lineSeparator = null;

src/main/java/org/apache/commons/codec/binary/Base64.java

diff --git a/src/main/java/org/apache/commons/codec/binary/Base64.java b/src/main/java/org/apache/commons/codec/binary/Base64.java
index 476d079..d40b3d4 100644
--- a/src/main/java/org/apache/commons/codec/binary/Base64.java
+++ b/src/main/java/org/apache/commons/codec/binary/Base64.java
@@ -596,8 +596,7 @@
             }
             if (lineLength > 0){ // null line-sep forces no chunking rather than throwing IAE
                 this.encodeSize = BYTES_PER_ENCODED_BLOCK + lineSeparator.length;
-                this.lineSeparator = new byte[lineSeparator.length];
-                System.arraycopy(lineSeparator, 0, this.lineSeparator, 0, lineSeparator.length);
+                this.lineSeparator = lineSeparator.clone();
             } else {
                 this.encodeSize = BYTES_PER_ENCODED_BLOCK;
                 this.lineSeparator = null;

src/main/java/org/apache/commons/codec/language/RefinedSoundex.java

diff --git a/src/main/java/org/apache/commons/codec/language/RefinedSoundex.java b/src/main/java/org/apache/commons/codec/language/RefinedSoundex.java
index 317f0e0..54dcd74 100644
--- a/src/main/java/org/apache/commons/codec/language/RefinedSoundex.java
+++ b/src/main/java/org/apache/commons/codec/language/RefinedSoundex.java
@@ -87,8 +87,7 @@
      *                  a given character
      */
     public RefinedSoundex(final char[] mapping) {
-        this.soundexMapping = new char[mapping.length];
-        System.arraycopy(mapping, 0, this.soundexMapping, 0, mapping.length);
+        this.soundexMapping = mapping.clone();
     }
 
     /**

src/main/java/org/apache/commons/codec/language/Soundex.java

diff --git a/src/main/java/org/apache/commons/codec/language/Soundex.java b/src/main/java/org/apache/commons/codec/language/Soundex.java
index 6acdac2..c2106dd 100644
--- a/src/main/java/org/apache/commons/codec/language/Soundex.java
+++ b/src/main/java/org/apache/commons/codec/language/Soundex.java
@@ -150,8 +150,7 @@
      *                  Mapping array to use when finding the corresponding code for a given character
      */
     public Soundex(final char[] mapping) {
-        this.soundexMapping = new char[mapping.length];
-        System.arraycopy(mapping, 0, this.soundexMapping, 0, mapping.length);
+        this.soundexMapping = mapping.clone();
         this.specialCaseHW = !hasMarker(this.soundexMapping);
     }