commit af54c01799ebf3ed613bfd9cc9e4934676b245fd
author Gary Gregory <garydgregory@gmail.com> Sun Jan 17 09:04:29 2021 -0500
committer Gary Gregory <garydgregory@gmail.com> Sun Jan 17 09:04:29 2021 -0500
tree 518e0855a790c4d46d10e19680fd0498612ea77e
parent 480802dcb6fcf351a33dc6f64c9cb5b11e8058be

Use isEmpty().

src/main/java/org/apache/commons/cli/HelpFormatter.java

diff --git a/src/main/java/org/apache/commons/cli/HelpFormatter.java b/src/main/java/org/apache/commons/cli/HelpFormatter.java
index 981ca5c..4e6fbcf 100644
--- a/src/main/java/org/apache/commons/cli/HelpFormatter.java
+++ b/src/main/java/org/apache/commons/cli/HelpFormatter.java
@@ -539,7 +539,7 @@
                           final String header, final Options options, final int leftPad,
                           final int descPad, final String footer, final boolean autoUsage)
     {
-        if (cmdLineSyntax == null || cmdLineSyntax.length() == 0)
+        if (cmdLineSyntax == null || cmdLineSyntax.isEmpty())
         {
             throw new IllegalArgumentException("cmdLineSyntax not provided");
         }
@@ -826,7 +826,7 @@
             if (option.hasArg())
             {
                 final String argName = option.getArgName();
-                if (argName != null && argName.length() == 0)
+                if (argName != null && argName.isEmpty())
                 {
                     // if the option has a blank argname
                     optBuf.append(' ');
@@ -1045,7 +1045,7 @@
      */
     protected String rtrim(final String s)
     {
-        if (s == null || s.length() == 0)
+        if (s == null || s.isEmpty())
         {
             return s;
         }