add logs
diff --git a/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/resource/NsxResource.java b/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/resource/NsxResource.java index 06f6f9c..6fbf417 100644 --- a/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/resource/NsxResource.java +++ b/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/resource/NsxResource.java
@@ -387,7 +387,8 @@ String privatePort = cmd.getPrivatePort(); String service = privatePort.contains("-") ? nsxApiClient.getServicePath(ruleName, privatePort, cmd.getProtocol(), null, null) : nsxApiClient.getNsxInfraServices(ruleName, privatePort, cmd.getProtocol(), null, null); - if (nsxApiClient.doesPfRuleExist(ruleName, tier1GatewayName, cmd.getNetworkResourceName())) { + if (nsxApiClient.doesPfRuleExist(ruleName, tier1GatewayName)) { + LOGGER.debug(String.format("Port forward rule for port: %s exits on NSX, not adding it again", privatePort)); return new NsxAnswer(cmd, true, null); } nsxApiClient.createPortForwardingRule(ruleName, tier1GatewayName, cmd.getNetworkResourceName(), cmd.getPublicIp(),
diff --git a/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxApiClient.java b/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxApiClient.java index 940464d..f3930d7 100644 --- a/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxApiClient.java +++ b/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxApiClient.java
@@ -572,12 +572,13 @@ } } - public boolean doesPfRuleExist(String ruleName, String tier1GatewayName, String networkName) { + public boolean doesPfRuleExist(String ruleName, String tier1GatewayName) { try { NatRules natService = (NatRules) nsxService.apply(NatRules.class); PolicyNatRule rule = natService.get(tier1GatewayName, NAT_ID, ruleName); return !Objects.isNull(rule); } catch (Error error) { + LOGGER.debug(String.format("Found a port forward rule named: %s on NSX", ruleName)); return false; } } @@ -781,6 +782,7 @@ return lbVirtualServer; } } catch (Exception e) { + LOGGER.debug(String.format("Found an LB virtual server named: %s on NSX", lbVSName)); return null; } return null;