Backport PR#6919 last commit (#218)
diff --git a/api/src/main/java/org/apache/cloudstack/consoleproxy/ConsoleAccessManager.java b/api/src/main/java/org/apache/cloudstack/consoleproxy/ConsoleAccessManager.java index c7e7f43..b1bd198 100644 --- a/api/src/main/java/org/apache/cloudstack/consoleproxy/ConsoleAccessManager.java +++ b/api/src/main/java/org/apache/cloudstack/consoleproxy/ConsoleAccessManager.java
@@ -18,9 +18,8 @@ import com.cloud.utils.component.Manager; import org.apache.cloudstack.api.command.user.consoleproxy.ConsoleEndpoint; -import org.apache.cloudstack.framework.config.Configurable; -public interface ConsoleAccessManager extends Manager, Configurable { +public interface ConsoleAccessManager extends Manager { ConsoleEndpoint generateConsoleEndpoint(Long vmId, String extraSecurityToken, String clientAddress);
diff --git a/server/src/main/java/org/apache/cloudstack/consoleproxy/ConsoleAccessManagerImpl.java b/server/src/main/java/org/apache/cloudstack/consoleproxy/ConsoleAccessManagerImpl.java index ce1aa64..b6522d4 100644 --- a/server/src/main/java/org/apache/cloudstack/consoleproxy/ConsoleAccessManagerImpl.java +++ b/server/src/main/java/org/apache/cloudstack/consoleproxy/ConsoleAccessManagerImpl.java
@@ -47,7 +47,6 @@ import com.google.gson.GsonBuilder; import org.apache.cloudstack.api.command.user.consoleproxy.ConsoleEndpoint; import org.apache.cloudstack.context.CallContext; -import org.apache.cloudstack.framework.config.ConfigKey; import org.apache.cloudstack.framework.security.keys.KeysManager; import org.apache.commons.codec.binary.Base64; import org.apache.commons.lang3.StringUtils; @@ -207,13 +206,14 @@ throw new CloudRuntimeException(msg); } - if (vm.getHostId() == null) { + Long hostId = vm.getState() != VirtualMachine.State.Migrating ? vm.getHostId() : vm.getLastHostId(); + if (hostId == null) { msg = "VM " + vmUuid + " lost host info, sending blank response for console access request"; s_logger.warn(msg); throw new CloudRuntimeException(msg); } - HostVO host = managementServer.getHostBy(vm.getHostId()); + HostVO host = managementServer.getHostBy(hostId); if (host == null) { msg = "VM " + vmUuid + "'s host does not exist, sending blank response for console access request"; s_logger.warn(msg); @@ -465,13 +465,4 @@ } } - @Override - public String getConfigComponentName() { - return ConsoleAccessManagerImpl.class.getSimpleName(); - } - - @Override - public ConfigKey<?>[] getConfigKeys() { - return new ConfigKey[] {}; - } }