plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java - cloudstack - Git at Google

 /*
  * Licensed to the Apache Software Foundation (ASF) under one
  * or more contributor license agreements.  See the NOTICE file
  * distributed with this work for additional information
  * regarding copyright ownership.  The ASF licenses this file
  * to you under the Apache License, Version 2.0 (the
  * "License"); you may not use this file except in compliance
  * with the License.  You may obtain a copy of the License at
  *
  *   http://www.apache.org/licenses/LICENSE-2.0
  *
  * Unless required by applicable law or agreed to in writing,
  * software distributed under the License is distributed on an
  * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
  * KIND, either express or implied.  See the License for the
  * specific language governing permissions and limitations
  * under the License.
  */
 package com.cloud.hypervisor.kvm.resource;

 import java.util.Arrays;
 import java.util.List;
 import java.util.Map;

 import javax.naming.ConfigurationException;

 import com.cloud.utils.exception.CloudRuntimeException;
 import org.apache.commons.lang.StringUtils;
 import org.apache.log4j.Logger;
 import org.libvirt.LibvirtException;

 import com.cloud.agent.api.to.NicTO;
 import com.cloud.exception.InternalErrorException;
 import com.cloud.hypervisor.kvm.resource.LibvirtVMDef.InterfaceDef;
 import com.cloud.network.Networks;
 import com.cloud.utils.NumbersUtil;
 import com.cloud.utils.net.NetUtils;
 import com.cloud.utils.script.OutputInterpreter;
 import com.cloud.utils.script.Script;

 public class OvsVifDriver extends VifDriverBase {
     private static final Logger s_logger = Logger.getLogger(OvsVifDriver.class);
     private int _timeout;

     protected static final String DPDK_PORT_PREFIX = "csdpdk-";

     @Override
     public void configure(Map<String, Object> params) throws ConfigurationException {
         super.configure(params);

         getPifs();

         String networkScriptsDir = (String)params.get("network.scripts.dir");
         if (networkScriptsDir == null) {
             networkScriptsDir = "scripts/vm/network/vnet";
         }

         String value = (String)params.get("scripts.timeout");
         _timeout = NumbersUtil.parseInt(value, 30 * 60) * 1000;
     }

     public void getPifs() {
         final String cmdout = Script.runSimpleBashScript("ovs-vsctl list-br | sed '{:q;N;s/\\n/%/g;t q}'");
         s_logger.debug("cmdout was " + cmdout);
         final List<String> bridges = Arrays.asList(cmdout.split("%"));
         for (final String bridge : bridges) {
             s_logger.debug("looking for pif for bridge " + bridge);
             // String pif = getOvsPif(bridge);
             // Not really interested in the pif name at this point for ovs
             // bridges
             final String pif = bridge;
             if (_libvirtComputingResource.isPublicBridge(bridge)) {
                 _pifs.put("public", pif);
             }
             if (_libvirtComputingResource.isGuestBridge(bridge)) {
                 _pifs.put("private", pif);
             }
             _pifs.put(bridge, pif);
         }
         s_logger.debug("done looking for pifs, no more bridges");
     }

     /**
      * Get the latest DPDK port number created on a DPDK enabled host
      */
     protected int getDpdkLatestPortNumberUsed() {
         s_logger.debug("Checking the last DPDK port created");
         String cmd = "ovs-vsctl show | grep Port | grep " + DPDK_PORT_PREFIX + " | " +
                 "awk '{ print $2 }' | sort -rV | head -1";
         String port = Script.runSimpleBashScript(cmd);
         int portNumber = 0;
         if (StringUtils.isNotBlank(port)) {
             String unquotedPort = port.replace("\"", "");
             String dpdkPortNumber = unquotedPort.split(DPDK_PORT_PREFIX)[1];
             portNumber = Integer.valueOf(dpdkPortNumber);
         }
         return portNumber;
     }

     /**
      * Get the next DPDK port name to be created
      */
     protected String getNextDpdkPort() {
         int portNumber = getDpdkLatestPortNumberUsed();
         return DPDK_PORT_PREFIX + String.valueOf(portNumber + 1);
     }

     /**
      * Add OVS port (if it does not exist) to bridge with DPDK support
      */
     protected void addDpdkPort(String bridgeName, String port, String vlan) {
         String cmd = String.format("ovs-vsctl add-port %s %s " +
                 "vlan_mode=access tag=%s " +
                 "-- set Interface %s type=dpdkvhostuser", bridgeName, port, vlan, port);
         s_logger.debug("DPDK property enabled, executing: " + cmd);
         Script.runSimpleBashScript(cmd);
     }

     /**
      * Check for additional extra 'dpdk-interface' configurations, return them appended
      */
     private String getExtraDpdkProperties(Map<String, String> extraConfig) {
         StringBuilder stringBuilder = new StringBuilder();
         for (String key : extraConfig.keySet()) {
             if (key.startsWith(LibvirtComputingResource.DPDK_INTERFACE_PREFIX)) {
                 stringBuilder.append(extraConfig.get(key));
             }
         }
         return stringBuilder.toString();
     }

     @Override
     public InterfaceDef plug(NicTO nic, String guestOsType, String nicAdapter, Map<String, String> extraConfig) throws InternalErrorException, LibvirtException {
         s_logger.debug("plugging nic=" + nic);

         LibvirtVMDef.InterfaceDef intf = new LibvirtVMDef.InterfaceDef();
         if (!_libvirtComputingResource.dpdkSupport || nic.isDpdkDisabled()) {
             // Let libvirt handle OVS ports creation when DPDK property is disabled or when it is enabled but disabled for the nic
             // For DPDK support, libvirt does not handle ports creation, invoke 'addDpdkPort' method
             intf.setVirtualPortType("openvswitch");
         }

         String vlanId = null;
         String logicalSwitchUuid = null;
         if (nic.getBroadcastType() == Networks.BroadcastDomainType.Vlan) {
             vlanId = Networks.BroadcastDomainType.getValue(nic.getBroadcastUri());
         } else if (nic.getBroadcastType() == Networks.BroadcastDomainType.Lswitch) {
             logicalSwitchUuid = Networks.BroadcastDomainType.getValue(nic.getBroadcastUri());
         } else if (nic.getBroadcastType() == Networks.BroadcastDomainType.Pvlan) {
             // TODO consider moving some of this functionality from NetUtils to Networks....
             vlanId = NetUtils.getPrimaryPvlanFromUri(nic.getBroadcastUri());
         }
         String trafficLabel = nic.getName();
         if (nic.getType() == Networks.TrafficType.Guest) {
             Integer networkRateKBps = (nic.getNetworkRateMbps() != null && nic.getNetworkRateMbps().intValue() != -1) ? nic.getNetworkRateMbps().intValue() * 128 : 0;
             if ((nic.getBroadcastType() == Networks.BroadcastDomainType.Vlan || nic.getBroadcastType() == Networks.BroadcastDomainType.Pvlan) &&
                     !vlanId.equalsIgnoreCase("untagged")) {
                 if (trafficLabel != null && !trafficLabel.isEmpty()) {
                     if (_libvirtComputingResource.dpdkSupport && !nic.isDpdkDisabled()) {
                         s_logger.debug("DPDK support enabled: configuring per traffic label " + trafficLabel);
                         if (StringUtils.isBlank(_libvirtComputingResource.dpdkOvsPath)) {
                             throw new CloudRuntimeException("DPDK is enabled on the host but no OVS path has been provided");
                         }
                         String port = getNextDpdkPort();
                         addDpdkPort(_pifs.get(trafficLabel), port, vlanId);
                         intf.defDpdkNet(_libvirtComputingResource.dpdkOvsPath, port, nic.getMac(), getGuestNicModel(guestOsType, nicAdapter), 0, getExtraDpdkProperties(extraConfig));
                     } else {
                         s_logger.debug("creating a vlan dev and bridge for guest traffic per traffic label " + trafficLabel);
                         intf.defBridgeNet(_pifs.get(trafficLabel), null, nic.getMac(), getGuestNicModel(guestOsType, nicAdapter), networkRateKBps);
                         intf.setVlanTag(Integer.parseInt(vlanId));
                     }
                 } else {
                     intf.defBridgeNet(_pifs.get("private"), null, nic.getMac(), getGuestNicModel(guestOsType, nicAdapter), networkRateKBps);
                     intf.setVlanTag(Integer.parseInt(vlanId));
                 }
             } else if (nic.getBroadcastType() == Networks.BroadcastDomainType.Lswitch || nic.getBroadcastType() == Networks.BroadcastDomainType.OpenDaylight) {
                 s_logger.debug("nic " + nic + " needs to be connected to LogicalSwitch " + logicalSwitchUuid);
                 intf.setVirtualPortInterfaceId(nic.getUuid());
                 String brName = (trafficLabel != null && !trafficLabel.isEmpty()) ? _pifs.get(trafficLabel) : _pifs.get("private");
                 intf.defBridgeNet(brName, null, nic.getMac(), getGuestNicModel(guestOsType, nicAdapter), networkRateKBps);
             } else if (nic.getBroadcastType() == Networks.BroadcastDomainType.Vswitch) {
                 String vnetId = Networks.BroadcastDomainType.getValue(nic.getBroadcastUri());
                 String brName = "OVSTunnel" + vnetId;
                 s_logger.debug("nic " + nic + " needs to be connected to LogicalSwitch " + brName);
                 intf.defBridgeNet(brName, null, nic.getMac(), getGuestNicModel(guestOsType, nicAdapter), networkRateKBps);
             } else if (nic.getBroadcastType() == Networks.BroadcastDomainType.Vsp) {
                 intf.setVirtualPortInterfaceId(nic.getUuid());
                 String brName = (trafficLabel != null && !trafficLabel.isEmpty()) ? _pifs.get(trafficLabel) : _pifs.get("private");
                 intf.defBridgeNet(brName, null, nic.getMac(), getGuestNicModel(guestOsType, nicAdapter), networkRateKBps);
             } else {
                 intf.defBridgeNet(_bridges.get("guest"), null, nic.getMac(), getGuestNicModel(guestOsType, nicAdapter), networkRateKBps);
             }
         } else if (nic.getType() == Networks.TrafficType.Control) {
             /* Make sure the network is still there */
             createControlNetwork(_bridges.get("linklocal"));
             intf.defBridgeNet(_bridges.get("linklocal"), null, nic.getMac(), getGuestNicModel(guestOsType, nicAdapter));
         } else if (nic.getType() == Networks.TrafficType.Public) {
             Integer networkRateKBps = (nic.getNetworkRateMbps() != null && nic.getNetworkRateMbps().intValue() != -1) ? nic.getNetworkRateMbps().intValue() * 128 : 0;
             if (nic.getBroadcastType() == Networks.BroadcastDomainType.Vlan && !vlanId.equalsIgnoreCase("untagged")) {
                 if (trafficLabel != null && !trafficLabel.isEmpty()) {
                     s_logger.debug("creating a vlan dev and bridge for public traffic per traffic label " + trafficLabel);
                     intf.defBridgeNet(_pifs.get(trafficLabel), null, nic.getMac(), getGuestNicModel(guestOsType, nicAdapter), networkRateKBps);
                     intf.setVlanTag(Integer.parseInt(vlanId));
                 } else {
                     intf.defBridgeNet(_pifs.get("public"), null, nic.getMac(), getGuestNicModel(guestOsType, nicAdapter), networkRateKBps);
                     intf.setVlanTag(Integer.parseInt(vlanId));
                 }
             } else {
                 intf.defBridgeNet(_bridges.get("public"), null, nic.getMac(), getGuestNicModel(guestOsType, nicAdapter), networkRateKBps);
             }
         } else if (nic.getType() == Networks.TrafficType.Management) {
             intf.defBridgeNet(_bridges.get("private"), null, nic.getMac(), getGuestNicModel(guestOsType, nicAdapter));
         } else if (nic.getType() == Networks.TrafficType.Storage) {
             String storageBrName = nic.getName() == null ? _bridges.get("private") : nic.getName();
             intf.defBridgeNet(storageBrName, null, nic.getMac(), getGuestNicModel(guestOsType, nicAdapter));
         }
         return intf;
     }

     @Override
     public void unplug(InterfaceDef iface) {
         // Libvirt apparently takes care of this, see BridgeVifDriver unplug
         if (_libvirtComputingResource.dpdkSupport) {
             // If DPDK is enabled, we'll need to cleanup the port as libvirt won't
             String dpdkPort = iface.getDpdkSourcePort();
             String cmd = String.format("ovs-vsctl del-port %s", dpdkPort);
             s_logger.debug("Removing DPDK port: " + dpdkPort);
             Script.runSimpleBashScript(cmd);
         }
     }


     @Override
     public void attach(LibvirtVMDef.InterfaceDef iface) {
         Script.runSimpleBashScript("ovs-vsctl add-port " + iface.getBrName() + " " + iface.getDevName());
     }

     @Override
     public void detach(LibvirtVMDef.InterfaceDef iface) {
         Script.runSimpleBashScript("ovs-vsctl port-to-br " + iface.getDevName() + " && ovs-vsctl del-port " + iface.getBrName() + " " + iface.getDevName());
     }

     private void deleteExitingLinkLocalRouteTable(String linkLocalBr) {
         Script command = new Script("/bin/bash", _timeout);
         command.add("-c");
         command.add("ip route | grep " + NetUtils.getLinkLocalCIDR());
         OutputInterpreter.AllLinesParser parser = new OutputInterpreter.AllLinesParser();
         String result = command.execute(parser);
         boolean foundLinkLocalBr = false;
         if (result == null && parser.getLines() != null) {
             String[] lines = parser.getLines().split("\\n");
             for (String line : lines) {
                 String[] tokens = line.split(" ");
                 if (!tokens[2].equalsIgnoreCase(linkLocalBr)) {
                     Script.runSimpleBashScript("ip route del " + NetUtils.getLinkLocalCIDR());
                 } else {
                     foundLinkLocalBr = true;
                 }
             }
         }
         if (!foundLinkLocalBr) {
             Script.runSimpleBashScript("ip address add 169.254.0.1/16 dev " + linkLocalBr + ";" + "ip route add " + NetUtils.getLinkLocalCIDR() + " dev " + linkLocalBr + " src " +
                     NetUtils.getLinkLocalGateway());
         }
     }

     @Override
     public void createControlNetwork(String privBrName) {
         deleteExitingLinkLocalRouteTable(privBrName);
         if (!isExistingBridge(privBrName)) {
             Script.runSimpleBashScript("ovs-vsctl add-br " + privBrName + "; ip link set " + privBrName + " up; ip address add 169.254.0.1/16 dev " + privBrName, _timeout);
         }
     }

     @Override
     public boolean isExistingBridge(String bridgeName) {
         Script command = new Script("/bin/sh", _timeout);
         command.add("-c");
         command.add("ovs-vsctl br-exists " + bridgeName);
         String result = command.execute(null);
         if ("0".equals(result)) {
             return true;
         } else {
             return false;
         }
     }
 }
	/*
	* Licensed to the Apache Software Foundation (ASF) under one
	* or more contributor license agreements. See the NOTICE file
	* distributed with this work for additional information
	* regarding copyright ownership. The ASF licenses this file
	* to you under the Apache License, Version 2.0 (the
	* "License"); you may not use this file except in compliance
	* with the License. You may obtain a copy of the License at
	*
	* http://www.apache.org/licenses/LICENSE-2.0
	*
	* Unless required by applicable law or agreed to in writing,
	* software distributed under the License is distributed on an
	* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
	* KIND, either express or implied. See the License for the
	* specific language governing permissions and limitations
	* under the License.
	*/
	package com.cloud.hypervisor.kvm.resource;

	import java.util.Arrays;
	import java.util.List;
	import java.util.Map;

	import javax.naming.ConfigurationException;

	import com.cloud.utils.exception.CloudRuntimeException;
	import org.apache.commons.lang.StringUtils;
	import org.apache.log4j.Logger;
	import org.libvirt.LibvirtException;

	import com.cloud.agent.api.to.NicTO;
	import com.cloud.exception.InternalErrorException;
	import com.cloud.hypervisor.kvm.resource.LibvirtVMDef.InterfaceDef;
	import com.cloud.network.Networks;
	import com.cloud.utils.NumbersUtil;
	import com.cloud.utils.net.NetUtils;
	import com.cloud.utils.script.OutputInterpreter;
	import com.cloud.utils.script.Script;

	public class OvsVifDriver extends VifDriverBase {
	private static final Logger s_logger = Logger.getLogger(OvsVifDriver.class);
	private int _timeout;

	protected static final String DPDK_PORT_PREFIX = "csdpdk-";

	@Override
	public void configure(Map<String, Object> params) throws ConfigurationException {
	super.configure(params);

	getPifs();

	String networkScriptsDir = (String)params.get("network.scripts.dir");
	if (networkScriptsDir == null) {
	networkScriptsDir = "scripts/vm/network/vnet";
	}

	String value = (String)params.get("scripts.timeout");
	_timeout = NumbersUtil.parseInt(value, 30 * 60) * 1000;
	}

	public void getPifs() {
	final String cmdout = Script.runSimpleBashScript("ovs-vsctl list-br \| sed '{:q;N;s/\\n/%/g;t q}'");
	s_logger.debug("cmdout was " + cmdout);
	final List<String> bridges = Arrays.asList(cmdout.split("%"));
	for (final String bridge : bridges) {
	s_logger.debug("looking for pif for bridge " + bridge);
	// String pif = getOvsPif(bridge);
	// Not really interested in the pif name at this point for ovs
	// bridges
	final String pif = bridge;
	if (_libvirtComputingResource.isPublicBridge(bridge)) {
	_pifs.put("public", pif);
	}
	if (_libvirtComputingResource.isGuestBridge(bridge)) {
	_pifs.put("private", pif);
	}
	_pifs.put(bridge, pif);
	}
	s_logger.debug("done looking for pifs, no more bridges");
	}

	/**
	* Get the latest DPDK port number created on a DPDK enabled host
	*/
	protected int getDpdkLatestPortNumberUsed() {
	s_logger.debug("Checking the last DPDK port created");
	String cmd = "ovs-vsctl show \| grep Port \| grep " + DPDK_PORT_PREFIX + " \| " +
	"awk '{ print $2 }' \| sort -rV \| head -1";
	String port = Script.runSimpleBashScript(cmd);
	int portNumber = 0;
	if (StringUtils.isNotBlank(port)) {
	String unquotedPort = port.replace("\"", "");
	String dpdkPortNumber = unquotedPort.split(DPDK_PORT_PREFIX)[1];
	portNumber = Integer.valueOf(dpdkPortNumber);
	}
	return portNumber;
	}

	/**
	* Get the next DPDK port name to be created
	*/
	protected String getNextDpdkPort() {
	int portNumber = getDpdkLatestPortNumberUsed();
	return DPDK_PORT_PREFIX + String.valueOf(portNumber + 1);
	}

	/**
	* Add OVS port (if it does not exist) to bridge with DPDK support
	*/
	protected void addDpdkPort(String bridgeName, String port, String vlan) {
	String cmd = String.format("ovs-vsctl add-port %s %s " +
	"vlan_mode=access tag=%s " +
	"-- set Interface %s type=dpdkvhostuser", bridgeName, port, vlan, port);
	s_logger.debug("DPDK property enabled, executing: " + cmd);
	Script.runSimpleBashScript(cmd);
	}

	/**
	* Check for additional extra 'dpdk-interface' configurations, return them appended
	*/
	private String getExtraDpdkProperties(Map<String, String> extraConfig) {
	StringBuilder stringBuilder = new StringBuilder();
	for (String key : extraConfig.keySet()) {
	if (key.startsWith(LibvirtComputingResource.DPDK_INTERFACE_PREFIX)) {
	stringBuilder.append(extraConfig.get(key));
	}
	}
	return stringBuilder.toString();
	}

	@Override
	public InterfaceDef plug(NicTO nic, String guestOsType, String nicAdapter, Map<String, String> extraConfig) throws InternalErrorException, LibvirtException {
	s_logger.debug("plugging nic=" + nic);

	LibvirtVMDef.InterfaceDef intf = new LibvirtVMDef.InterfaceDef();
	if (!_libvirtComputingResource.dpdkSupport \|\| nic.isDpdkDisabled()) {
	// Let libvirt handle OVS ports creation when DPDK property is disabled or when it is enabled but disabled for the nic
	// For DPDK support, libvirt does not handle ports creation, invoke 'addDpdkPort' method
	intf.setVirtualPortType("openvswitch");
	}

	String vlanId = null;
	String logicalSwitchUuid = null;
	if (nic.getBroadcastType() == Networks.BroadcastDomainType.Vlan) {
	vlanId = Networks.BroadcastDomainType.getValue(nic.getBroadcastUri());
	} else if (nic.getBroadcastType() == Networks.BroadcastDomainType.Lswitch) {
	logicalSwitchUuid = Networks.BroadcastDomainType.getValue(nic.getBroadcastUri());
	} else if (nic.getBroadcastType() == Networks.BroadcastDomainType.Pvlan) {
	// TODO consider moving some of this functionality from NetUtils to Networks....
	vlanId = NetUtils.getPrimaryPvlanFromUri(nic.getBroadcastUri());
	}
	String trafficLabel = nic.getName();
	if (nic.getType() == Networks.TrafficType.Guest) {
	Integer networkRateKBps = (nic.getNetworkRateMbps() != null && nic.getNetworkRateMbps().intValue() != -1) ? nic.getNetworkRateMbps().intValue() * 128 : 0;
	if ((nic.getBroadcastType() == Networks.BroadcastDomainType.Vlan \|\| nic.getBroadcastType() == Networks.BroadcastDomainType.Pvlan) &&
	!vlanId.equalsIgnoreCase("untagged")) {
	if (trafficLabel != null && !trafficLabel.isEmpty()) {
	if (_libvirtComputingResource.dpdkSupport && !nic.isDpdkDisabled()) {
	s_logger.debug("DPDK support enabled: configuring per traffic label " + trafficLabel);
	if (StringUtils.isBlank(_libvirtComputingResource.dpdkOvsPath)) {
	throw new CloudRuntimeException("DPDK is enabled on the host but no OVS path has been provided");
	}
	String port = getNextDpdkPort();
	addDpdkPort(_pifs.get(trafficLabel), port, vlanId);
	intf.defDpdkNet(_libvirtComputingResource.dpdkOvsPath, port, nic.getMac(), getGuestNicModel(guestOsType, nicAdapter), 0, getExtraDpdkProperties(extraConfig));
	} else {
	s_logger.debug("creating a vlan dev and bridge for guest traffic per traffic label " + trafficLabel);
	intf.defBridgeNet(_pifs.get(trafficLabel), null, nic.getMac(), getGuestNicModel(guestOsType, nicAdapter), networkRateKBps);
	intf.setVlanTag(Integer.parseInt(vlanId));
	}
	} else {
	intf.defBridgeNet(_pifs.get("private"), null, nic.getMac(), getGuestNicModel(guestOsType, nicAdapter), networkRateKBps);
	intf.setVlanTag(Integer.parseInt(vlanId));
	}
	} else if (nic.getBroadcastType() == Networks.BroadcastDomainType.Lswitch \|\| nic.getBroadcastType() == Networks.BroadcastDomainType.OpenDaylight) {
	s_logger.debug("nic " + nic + " needs to be connected to LogicalSwitch " + logicalSwitchUuid);
	intf.setVirtualPortInterfaceId(nic.getUuid());
	String brName = (trafficLabel != null && !trafficLabel.isEmpty()) ? _pifs.get(trafficLabel) : _pifs.get("private");
	intf.defBridgeNet(brName, null, nic.getMac(), getGuestNicModel(guestOsType, nicAdapter), networkRateKBps);
	} else if (nic.getBroadcastType() == Networks.BroadcastDomainType.Vswitch) {
	String vnetId = Networks.BroadcastDomainType.getValue(nic.getBroadcastUri());
	String brName = "OVSTunnel" + vnetId;
	s_logger.debug("nic " + nic + " needs to be connected to LogicalSwitch " + brName);
	intf.defBridgeNet(brName, null, nic.getMac(), getGuestNicModel(guestOsType, nicAdapter), networkRateKBps);
	} else if (nic.getBroadcastType() == Networks.BroadcastDomainType.Vsp) {
	intf.setVirtualPortInterfaceId(nic.getUuid());
	String brName = (trafficLabel != null && !trafficLabel.isEmpty()) ? _pifs.get(trafficLabel) : _pifs.get("private");
	intf.defBridgeNet(brName, null, nic.getMac(), getGuestNicModel(guestOsType, nicAdapter), networkRateKBps);
	} else {
	intf.defBridgeNet(_bridges.get("guest"), null, nic.getMac(), getGuestNicModel(guestOsType, nicAdapter), networkRateKBps);
	}
	} else if (nic.getType() == Networks.TrafficType.Control) {
	/* Make sure the network is still there */
	createControlNetwork(_bridges.get("linklocal"));
	intf.defBridgeNet(_bridges.get("linklocal"), null, nic.getMac(), getGuestNicModel(guestOsType, nicAdapter));
	} else if (nic.getType() == Networks.TrafficType.Public) {
	Integer networkRateKBps = (nic.getNetworkRateMbps() != null && nic.getNetworkRateMbps().intValue() != -1) ? nic.getNetworkRateMbps().intValue() * 128 : 0;
	if (nic.getBroadcastType() == Networks.BroadcastDomainType.Vlan && !vlanId.equalsIgnoreCase("untagged")) {
	if (trafficLabel != null && !trafficLabel.isEmpty()) {
	s_logger.debug("creating a vlan dev and bridge for public traffic per traffic label " + trafficLabel);
	intf.defBridgeNet(_pifs.get(trafficLabel), null, nic.getMac(), getGuestNicModel(guestOsType, nicAdapter), networkRateKBps);
	intf.setVlanTag(Integer.parseInt(vlanId));
	} else {
	intf.defBridgeNet(_pifs.get("public"), null, nic.getMac(), getGuestNicModel(guestOsType, nicAdapter), networkRateKBps);
	intf.setVlanTag(Integer.parseInt(vlanId));
	}
	} else {
	intf.defBridgeNet(_bridges.get("public"), null, nic.getMac(), getGuestNicModel(guestOsType, nicAdapter), networkRateKBps);
	}
	} else if (nic.getType() == Networks.TrafficType.Management) {
	intf.defBridgeNet(_bridges.get("private"), null, nic.getMac(), getGuestNicModel(guestOsType, nicAdapter));
	} else if (nic.getType() == Networks.TrafficType.Storage) {
	String storageBrName = nic.getName() == null ? _bridges.get("private") : nic.getName();
	intf.defBridgeNet(storageBrName, null, nic.getMac(), getGuestNicModel(guestOsType, nicAdapter));
	}
	return intf;
	}

	@Override
	public void unplug(InterfaceDef iface) {
	// Libvirt apparently takes care of this, see BridgeVifDriver unplug
	if (_libvirtComputingResource.dpdkSupport) {
	// If DPDK is enabled, we'll need to cleanup the port as libvirt won't
	String dpdkPort = iface.getDpdkSourcePort();
	String cmd = String.format("ovs-vsctl del-port %s", dpdkPort);
	s_logger.debug("Removing DPDK port: " + dpdkPort);
	Script.runSimpleBashScript(cmd);
	}
	}


	@Override
	public void attach(LibvirtVMDef.InterfaceDef iface) {
	Script.runSimpleBashScript("ovs-vsctl add-port " + iface.getBrName() + " " + iface.getDevName());
	}

	@Override
	public void detach(LibvirtVMDef.InterfaceDef iface) {
	Script.runSimpleBashScript("ovs-vsctl port-to-br " + iface.getDevName() + " && ovs-vsctl del-port " + iface.getBrName() + " " + iface.getDevName());
	}

	private void deleteExitingLinkLocalRouteTable(String linkLocalBr) {
	Script command = new Script("/bin/bash", _timeout);
	command.add("-c");
	command.add("ip route \| grep " + NetUtils.getLinkLocalCIDR());
	OutputInterpreter.AllLinesParser parser = new OutputInterpreter.AllLinesParser();
	String result = command.execute(parser);
	boolean foundLinkLocalBr = false;
	if (result == null && parser.getLines() != null) {
	String[] lines = parser.getLines().split("\\n");
	for (String line : lines) {
	String[] tokens = line.split(" ");
	if (!tokens[2].equalsIgnoreCase(linkLocalBr)) {
	Script.runSimpleBashScript("ip route del " + NetUtils.getLinkLocalCIDR());
	} else {
	foundLinkLocalBr = true;
	}
	}
	}
	if (!foundLinkLocalBr) {
	Script.runSimpleBashScript("ip address add 169.254.0.1/16 dev " + linkLocalBr + ";" + "ip route add " + NetUtils.getLinkLocalCIDR() + " dev " + linkLocalBr + " src " +
	NetUtils.getLinkLocalGateway());
	}
	}

	@Override
	public void createControlNetwork(String privBrName) {
	deleteExitingLinkLocalRouteTable(privBrName);
	if (!isExistingBridge(privBrName)) {
	Script.runSimpleBashScript("ovs-vsctl add-br " + privBrName + "; ip link set " + privBrName + " up; ip address add 169.254.0.1/16 dev " + privBrName, _timeout);
	}
	}

	@Override
	public boolean isExistingBridge(String bridgeName) {
	Script command = new Script("/bin/sh", _timeout);
	command.add("-c");
	command.add("ovs-vsctl br-exists " + bridgeName);
	String result = command.execute(null);
	if ("0".equals(result)) {
	return true;
	} else {
	return false;
	}
	}
	}