PAX: fix pax_inject_fault flaky test Move the failing INSERT inside -- start_ignore so non-deterministic crash recovery messages (DETAIL/HINT/WARNING from postmaster killing other backends after a PANIC) are prefixed with GP_IGNORE: by atmsort.pm and ignored by the diff comparison.
diff --git a/contrib/pax_storage/expected/pax_inject_fault.out b/contrib/pax_storage/expected/pax_inject_fault.out index 9d7ff49..0868fe1 100644 --- a/contrib/pax_storage/expected/pax_inject_fault.out +++ b/contrib/pax_storage/expected/pax_inject_fault.out
@@ -25,10 +25,9 @@ Success: (3 rows) --- failed because of fault injection -insert into t_insert select generate_series(1,10); -ERROR: fault triggered, fault name:'orc_writer_write_tuple' fault type:'panic' -- start_ignore +-- failed because of fault injection; crash recovery messages are non-deterministic +insert into t_insert select generate_series(1,10); -- clear the fault inject, so the next insert will success. -- put the reset operation in ignore range select gp_inject_fault('orc_writer_write_tuple','reset',dbid) FROM gp_segment_configuration WHERE role = 'p' AND content > -1;
diff --git a/contrib/pax_storage/sql/pax_inject_fault.sql b/contrib/pax_storage/sql/pax_inject_fault.sql index 0cced2b..e210023 100644 --- a/contrib/pax_storage/sql/pax_inject_fault.sql +++ b/contrib/pax_storage/sql/pax_inject_fault.sql
@@ -2,10 +2,10 @@ select gp_inject_fault_infinite('fts_probe','skip',dbid) FROM gp_segment_configuration WHERE role = 'p' AND content = -1; select gp_request_fts_probe_scan(); select gp_inject_fault('orc_writer_write_tuple','panic',dbid) FROM gp_segment_configuration WHERE role = 'p' AND content > -1; --- failed because of fault injection -insert into t_insert select generate_series(1,10); -- start_ignore +-- failed because of fault injection; crash recovery messages are non-deterministic +insert into t_insert select generate_series(1,10); -- clear the fault inject, so the next insert will success. -- put the reset operation in ignore range select gp_inject_fault('orc_writer_write_tuple','reset',dbid) FROM gp_segment_configuration WHERE role = 'p' AND content > -1;