commit | af0060f1325bf8edf74171f60326a3427e13e01d | [log] [tgz] |
---|---|---|
author | Francisco Guerrero <frankgh@apache.org> | Thu Mar 07 16:25:18 2024 -0800 |
committer | GitHub <noreply@github.com> | Thu Mar 07 16:25:18 2024 -0800 |
tree | 5c0e03641be67064edc3a481ebf207bf49b920ca | |
parent | d19a1b9a112614d378b42bb136cc84ae9cc6213a [diff] |
CASSANDRASC-113 Fix flaky JmxClientTest (#105) In this PR, we fix the race condition that occurs when determining the port number to use for the registry. Currently, the port is determined in the `availablePort` method, where a socket is determined by using port 0. The OS will assign a port number for the socket, but we immediately close the socket, and use the determined port number to run the test. This PR brings a better approach by directly using port 0 while creating the registry, thus avoiding the intermediate step and directly using the port that originally was assigned to the registry without releasing it until the end of the test. Additionally in this PR, we rename the integration test JmxClientTest which name is colliding with the unit test. This allows for a better IDE integration and debugging experience. Patch by Francisco Guerrero; Reviewed by Yifan Cai for CASSANDRASC-113
This is a Sidecar for the highly scalable Apache Cassandra database. For more information, see the Apache Cassandra web site and CIP-1.
This is project is still WIP.
We depend on the Cassandra in-jvm dtest framework for testing. Because these jars are not published, you must manually build the dtest jars before you can build the project.
./scripts/build-dtest-jars.sh
The build script supports two parameters:
REPO
- the Cassandra git repository to use for the source files. This is helpful if you need to test with a fork of the Cassandra codebase.git@github.com:apache/cassandra.git
BRANCHES
- a space-delimited list of branches to build. -default: "cassandra-4.1 trunk"
Remove any versions you may not want to test with. We recommend at least the latest (released) 4.X series and trunk
. See Testing for more details on how to choose which Cassandra versions to use while testing.
For multi-node in-jvm dtests, network aliases will need to be setup for each Cassandra node. The tests assume each node's ip address is 127.0.0.x, where x is the node id.
For example if you populated your cluster with 3 nodes, create interfaces for 127.0.0.2 and 127.0.0.3 (the first node of course uses 127.0.0.1).
To get up and running, create a temporary alias for every node except the first:
for i in {2..20}; do sudo ifconfig lo0 alias "127.0.0.${i}"; done
After you clone the git repo, you can use the gradle wrapper to build and run the project. Make sure you have Apache Cassandra running on the host & port specified in conf/sidecar.yaml
.
$ ./gradlew run
While setting up cassandra instance, make sure the data directories of cassandra are in the path stored in sidecar.yaml file, else modify data directories path to point to the correct directories for stream APIs to work.
The test framework is set up to run 4.1 and 5.1 (Trunk) tests (see TestVersionSupplier.java
) by default. You can change this via the Java property cassandra.sidecar.versions_to_test
by supplying a comma-delimited string. For example, -Dcassandra.sidecar.versions_to_test=4.0,4.1,5.1
.
You will need to use the “Add Projects” function of CircleCI to set up CircleCI on your fork. When promoted to create a branch, do not replace the CircleCI config, choose the option to do it manually. CircleCI will pick up the in project configuration.
We warmly welcome and appreciate contributions from the community. Please see CONTRIBUTING.md if you wish to submit pull requests.