commit a84d04a86349ad9375cce480f98441b10619a47b
author Matt Benson <mbenson@apache.org> Tue Mar 27 10:22:29 2018 -0500
committer Matt Benson <mbenson@apache.org> Tue Oct 16 12:28:18 2018 -0500
tree 6a9bca86989f0f7b9081839d9c2f3610f6bd61bb
parent 520075aceac601ac5cb33ecde87c00a8519760d5

implement validationAppliesTo rules

bval-jsr/src/main/java/org/apache/bval/jsr/descriptor/ConstraintD.java

diff --git a/bval-jsr/src/main/java/org/apache/bval/jsr/descriptor/ConstraintD.java b/bval-jsr/src/main/java/org/apache/bval/jsr/descriptor/ConstraintD.java
index bd8c1f8..d8bb932 100644
--- a/bval-jsr/src/main/java/org/apache/bval/jsr/descriptor/ConstraintD.java
+++ b/bval-jsr/src/main/java/org/apache/bval/jsr/descriptor/ConstraintD.java
@@ -20,6 +20,8 @@
 
 import java.lang.annotation.Annotation;
 import java.lang.annotation.ElementType;
+import java.lang.reflect.AnnotatedElement;
+import java.lang.reflect.Executable;
 import java.util.Arrays;
 import java.util.Collections;
 import java.util.List;
@@ -75,6 +77,7 @@
     private final boolean reportAsSingle;
     private final ValidateUnwrappedValue valueUnwrapping;
     private final Map<String, Object> attributes;
+    private final ConstraintTarget validationAppliesTo;
 
     private final Set<ConstraintDescriptor<?>> composingConstraints;
     private final List<Class<? extends ConstraintValidator<A, ?>>> constraintValidatorClasses;
@@ -89,6 +92,7 @@
         reportAsSingle = annotation.annotationType().isAnnotationPresent(ReportAsSingleViolation.class);
         valueUnwrapping = computeValidateUnwrappedValue();
         attributes = AnnotationsManager.readAttributes(annotation);
+        validationAppliesTo = computeValidationAppliesTo(meta.getElementType());
 
         Validate.notNull(validatorFactory, "validatorFactory");
         composingConstraints = computeComposingConstraints(validatorFactory);
@@ -137,7 +141,7 @@
 
     @Override
     public ConstraintTarget getValidationAppliesTo() {
-        return read(ConstraintAnnotationAttributes.VALIDATION_APPLIES_TO);
+        return validationAppliesTo;
     }
 
     @Override
@@ -224,4 +228,28 @@
         }
         return result;
     }
+
+    private ConstraintTarget computeValidationAppliesTo(ElementType elementType) {
+        final ConstraintTarget result = read(ConstraintAnnotationAttributes.VALIDATION_APPLIES_TO);
+        if (result != null) {
+            final AnnotatedElement host = meta.getHost();
+            Exceptions.raiseUnless(host instanceof Executable, ConstraintDeclarationException::new, "Illegal %s on %s",
+                result, host);
+
+            switch (result) {
+            case PARAMETERS:
+                Exceptions.raiseIf(((Executable) host).getParameterCount() == 0, ConstraintDeclarationException::new,
+                    "Illegal specification of %s on %s with no parameters", result, elementType);
+                break;
+            case RETURN_VALUE:
+                Exceptions.raiseIf(Void.TYPE.equals(meta.getType()), ConstraintDeclarationException::new,
+                    "Illegal %s on %s method %s", result, Void.TYPE, host);
+                break;
+            case IMPLICIT:
+                // handled in ReflectionBuilder
+            default:
+            }
+        }
+        return result;
+    }
 }