commit 9ff82f7054eb42783f107c4b18b91f70dfa6e499
author Jürg Billeter <j@bitron.ch> Wed Oct 28 11:10:24 2020 +0100
committer Jürg Billeter <j@bitron.ch> Tue Jun 08 10:40:43 2021 +0200
tree 676925b6e13814853830aa8b84312be21d67ed87
parent eb12d1c6d537b787dc97922d16b474bf459fe8f6

element.py: Move get_logs() to internal API

src/buildstream/_elementproxy.py

diff --git a/src/buildstream/_elementproxy.py b/src/buildstream/_elementproxy.py
index a7b1f09..53780ea 100644
--- a/src/buildstream/_elementproxy.py
+++ b/src/buildstream/_elementproxy.py
@@ -146,9 +146,6 @@
     def get_variable(self, varname: str) -> Optional[str]:
         return cast("Element", self._plugin).get_variable(varname)
 
-    def get_logs(self) -> List[str]:
-        return cast("Element", self._plugin).get_logs()
-
     ##############################################################
     #                   Element Internal APIs                    #
     ##############################################################

src/buildstream/_stream.py

diff --git a/src/buildstream/_stream.py b/src/buildstream/_stream.py
index d03480e..520483b 100644
--- a/src/buildstream/_stream.py
+++ b/src/buildstream/_stream.py
@@ -796,7 +796,7 @@
                 self._context.messenger.warn("{} is cached without log files".format(ref))
                 continue
 
-            artifact_logs[obj.name] = obj.get_logs()
+            artifact_logs[obj.name] = obj._get_logs()
 
         return artifact_logs
 

src/buildstream/element.py

diff --git a/src/buildstream/element.py b/src/buildstream/element.py
index 8a484a2..bba3506 100644
--- a/src/buildstream/element.py
+++ b/src/buildstream/element.py
@@ -839,14 +839,6 @@
         self.__batch_prepare_assemble_flags = flags
         self.__batch_prepare_assemble_collect = collect
 
-    def get_logs(self) -> List[str]:
-        """Obtain a list of log file paths
-
-        Returns:
-           A list of log file paths
-        """
-        return cast(Artifact, self.__artifact).get_logs()
-
     #############################################################
     #            Private Methods used in BuildStream            #
     #############################################################
@@ -2498,6 +2490,16 @@
             self.__whitelist_regex = re.compile(expression)
         return self.__whitelist_regex.match(os.path.join(os.sep, path))
 
+    # _get_logs()
+    #
+    # Obtain a list of log file paths
+    #
+    # Returns:
+    #    A list of log file paths
+    #
+    def _get_logs(self) -> List[str]:
+        return cast(Artifact, self.__artifact).get_logs()
+
     #############################################################
     #                   Private Local Methods                   #
     #############################################################