ISSUE #2454: Typo of naming LedgerStorage#setExplicitlac
Fix #2454 .
Reviewers: Enrico Olivelli <eolivelli@gmail.com>
This closes #2456 from Technoboy-/issue-2454, closes #2454
diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java
index 5d4ec0e..6da8d21 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java
@@ -307,7 +307,7 @@
}
@Override
- public void setExplicitlac(long ledgerId, ByteBuf lac) throws IOException {
+ public void setExplicitLac(long ledgerId, ByteBuf lac) throws IOException {
ledgerCache.setExplicitLac(ledgerId, lac);
}
diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptorImpl.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptorImpl.java
index fcad36e..7f9261b 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptorImpl.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptorImpl.java
@@ -79,7 +79,7 @@
@Override
void setExplicitLac(ByteBuf lac) throws IOException {
- ledgerStorage.setExplicitlac(ledgerId, lac);
+ ledgerStorage.setExplicitLac(ledgerId, lac);
}
@Override
diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerStorage.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerStorage.java
index d371520..3369c55 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerStorage.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerStorage.java
@@ -186,7 +186,7 @@
*/
void registerLedgerDeletionListener(LedgerDeletionListener listener);
- void setExplicitlac(long ledgerId, ByteBuf lac) throws IOException;
+ void setExplicitLac(long ledgerId, ByteBuf lac) throws IOException;
ByteBuf getExplicitLac(long ledgerId);
diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SortedLedgerStorage.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SortedLedgerStorage.java
index c1ad591..60822b8 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SortedLedgerStorage.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SortedLedgerStorage.java
@@ -256,8 +256,8 @@
}
@Override
- public void setExplicitlac(long ledgerId, ByteBuf lac) throws IOException {
- interleavedLedgerStorage.setExplicitlac(ledgerId, lac);
+ public void setExplicitLac(long ledgerId, ByteBuf lac) throws IOException {
+ interleavedLedgerStorage.setExplicitLac(ledgerId, lac);
}
@Override
diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/DbLedgerStorage.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/DbLedgerStorage.java
index 73d254a..202d7fc 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/DbLedgerStorage.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/DbLedgerStorage.java
@@ -242,8 +242,8 @@
}
@Override
- public void setExplicitlac(long ledgerId, ByteBuf lac) throws IOException {
- getLedgerSorage(ledgerId).setExplicitlac(ledgerId, lac);
+ public void setExplicitLac(long ledgerId, ByteBuf lac) throws IOException {
+ getLedgerSorage(ledgerId).setExplicitLac(ledgerId, lac);
}
@Override
diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/SingleDirectoryDbLedgerStorage.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/SingleDirectoryDbLedgerStorage.java
index 9ff35bf..73be9b3 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/SingleDirectoryDbLedgerStorage.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/SingleDirectoryDbLedgerStorage.java
@@ -767,7 +767,7 @@
}
@Override
- public void setExplicitlac(long ledgerId, ByteBuf lac) throws IOException {
+ public void setExplicitLac(long ledgerId, ByteBuf lac) throws IOException {
getOrAddLedgerInfo(ledgerId).setExplicitLac(lac);
}
diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieNettyServer.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieNettyServer.java
index d6e6f21..90efed7 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieNettyServer.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieNettyServer.java
@@ -189,7 +189,7 @@
for (Channel channel : allChannels) {
// To suspend processing in the bookie, submit a task
// that keeps the event loop busy until resume is
- // explicitely invoked
+ // explicitly invoked
channel.eventLoop().submit(() -> {
while (suspended && isRunning()) {
try {
diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/util/DiskChecker.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/util/DiskChecker.java
index a2e7017..e108b59 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/util/DiskChecker.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/util/DiskChecker.java
@@ -140,7 +140,7 @@
* Directory to check for the disk space
* @throws DiskOutOfSpaceException
* Throws {@link DiskOutOfSpaceException} if available space is
- * less than threshhold.
+ * less than threshold.
*/
@VisibleForTesting
float checkDiskFull(File dir) throws DiskOutOfSpaceException, DiskWarnThresholdException {
@@ -239,7 +239,7 @@
* @throws DiskWarnThresholdException
* If disk has less than configured amount of free space.
* @throws DiskOutOfSpaceException
- * If disk is full or having less space than threshhold
+ * If disk is full or having less space than threshold
*/
public float checkDir(File dir) throws DiskErrorException,
DiskOutOfSpaceException, DiskWarnThresholdException {
diff --git a/bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/SyncThreadTest.java b/bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/SyncThreadTest.java
index 9529b27..2de8395 100644
--- a/bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/SyncThreadTest.java
+++ b/bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/SyncThreadTest.java
@@ -340,7 +340,7 @@
}
@Override
- public void setExplicitlac(long ledgerId, ByteBuf lac) {
+ public void setExplicitLac(long ledgerId, ByteBuf lac) {
}
@Override
diff --git a/bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/storage/ldb/DbLedgerStorageBookieTest.java b/bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/storage/ldb/DbLedgerStorageBookieTest.java
index 11c3ef3..9babab8 100644
--- a/bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/storage/ldb/DbLedgerStorageBookieTest.java
+++ b/bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/storage/ldb/DbLedgerStorageBookieTest.java
@@ -47,7 +47,7 @@
// Leave it empty to pickup default
baseConf.setProperty(DbLedgerStorage.WRITE_CACHE_MAX_SIZE_MB, "");
- // Configure explicitely with a int object
+ // Configure explicitly with a int object
baseConf.setProperty(DbLedgerStorage.READ_AHEAD_CACHE_MAX_SIZE_MB, 16);
}
diff --git a/bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/GcLedgersTest.java b/bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/GcLedgersTest.java
index ce53598..b467d86 100644
--- a/bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/GcLedgersTest.java
+++ b/bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/GcLedgersTest.java
@@ -600,7 +600,7 @@
}
@Override
- public void setExplicitlac(long ledgerId, ByteBuf lac) throws IOException {
+ public void setExplicitLac(long ledgerId, ByteBuf lac) throws IOException {
}
@Override
diff --git a/bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerManagerTestCase.java b/bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerManagerTestCase.java
index 4acc3e7..cb85f4e 100644
--- a/bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerManagerTestCase.java
+++ b/bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerManagerTestCase.java
@@ -282,7 +282,7 @@
}
@Override
- public void setExplicitlac(long ledgerId, ByteBuf lac) throws IOException {
+ public void setExplicitLac(long ledgerId, ByteBuf lac) throws IOException {
}
@Override
