commit bb5f3057db1d5b9514954f75b6bf64b43bcfd1a3
author Steven Fackler <sfackler@gmail.com> Sat Feb 20 08:44:22 2021 -0500
committer Andy Grove <andygrove@nvidia.com> Fri Mar 12 13:08:11 2021 -0700
tree e5fb3acdc37606b8354d692525da9cec4bb0588a
parent d613aa68789288d3503dfbd8376a41f2d28b6c9d

ARROW-11681: [Rust] Don't unwrap in IPC writers

A common reason a writer would be dropping without finishing is because
the underlying stream returned an earlier error. In that case, the
destructor will probably also encounter an error, resulting in a panic.
Instead just ignore the result from finish, mirroring the behavior of
the standard library's BufWriter.

Closes #9520 from sfackler/ipc-panic

Authored-by: Steven Fackler <sfackler@gmail.com>
Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>

rust/arrow/src/ipc/writer.rs

diff --git a/rust/arrow/src/ipc/writer.rs b/rust/arrow/src/ipc/writer.rs
index 688829a..bc5e4cc 100644
--- a/rust/arrow/src/ipc/writer.rs
+++ b/rust/arrow/src/ipc/writer.rs
@@ -460,7 +460,7 @@
 impl<W: Write> Drop for FileWriter<W> {
     fn drop(&mut self) {
         if !self.finished {
-            self.finish().unwrap();
+            let _ = self.finish();
         }
     }
 }
@@ -542,7 +542,7 @@
 impl<W: Write> Drop for StreamWriter<W> {
     fn drop(&mut self) {
         if !self.finished {
-            self.finish().unwrap();
+            let _ = self.finish();
         }
     }
 }