ARROW-101: Fix java compiler warnings
Fixes several warnings emitted by java compiler regarding the use of raw types and unclosed resources.
Author: Laurent Goujon <laurent.goujon@online.fr>
Closes #60 from laurentgo/laurent/fix-generic-warnings and squashes the following commits:
96ccc67 [Laurent Goujon] [ARROW-101] Fix java compiler resources warnings
61bde83 [Laurent Goujon] [ARROW-101] Fix java compiler rawtypes warnings
diff --git a/java/vector/src/main/java/org/apache/arrow/vector/ZeroVector.java b/java/vector/src/main/java/org/apache/arrow/vector/ZeroVector.java
index 78de870..c94e8d1 100644
--- a/java/vector/src/main/java/org/apache/arrow/vector/ZeroVector.java
+++ b/java/vector/src/main/java/org/apache/arrow/vector/ZeroVector.java
@@ -19,6 +19,7 @@
import io.netty.buffer.ArrowBuf;
+import java.util.Collections;
import java.util.Iterator;
import org.apache.arrow.memory.BufferAllocator;
@@ -109,8 +110,8 @@
// }
@Override
- public Iterator iterator() {
- return Iterators.emptyIterator();
+ public Iterator<ValueVector> iterator() {
+ return Collections.emptyIterator();
}
@Override
diff --git a/java/vector/src/main/java/org/apache/arrow/vector/complex/impl/PromotableWriter.java b/java/vector/src/main/java/org/apache/arrow/vector/complex/impl/PromotableWriter.java
index ea62e02..45509f6 100644
--- a/java/vector/src/main/java/org/apache/arrow/vector/complex/impl/PromotableWriter.java
+++ b/java/vector/src/main/java/org/apache/arrow/vector/complex/impl/PromotableWriter.java
@@ -85,16 +85,16 @@
state = State.SINGLE;
vector = v;
type = v.getField().getType().getMinorType();
- Class writerClass = BasicTypeHelper
+ Class<?> writerClass = BasicTypeHelper
.getWriterImpl(v.getField().getType().getMinorType(), v.getField().getDataMode());
if (writerClass.equals(SingleListWriter.class)) {
writerClass = UnionListWriter.class;
}
- Class vectorClass = BasicTypeHelper.getValueVectorClass(v.getField().getType().getMinorType(), v.getField()
+ Class<?> vectorClass = BasicTypeHelper.getValueVectorClass(v.getField().getType().getMinorType(), v.getField()
.getDataMode());
try {
- Constructor constructor = null;
- for (Constructor c : writerClass.getConstructors()) {
+ Constructor<?> constructor = null;
+ for (Constructor<?> c : writerClass.getConstructors()) {
if (c.getParameterTypes().length == 3) {
constructor = c;
}
diff --git a/java/vector/src/main/java/org/apache/arrow/vector/util/JsonStringArrayList.java b/java/vector/src/main/java/org/apache/arrow/vector/util/JsonStringArrayList.java
index 7aeaa12..6291bfe 100644
--- a/java/vector/src/main/java/org/apache/arrow/vector/util/JsonStringArrayList.java
+++ b/java/vector/src/main/java/org/apache/arrow/vector/util/JsonStringArrayList.java
@@ -42,7 +42,7 @@
if (!(obj instanceof List)) {
return false;
}
- List other = (List) obj;
+ List<?> other = (List<?>) obj;
return this.size() == other.size() && this.containsAll(other);
}
diff --git a/java/vector/src/main/java/org/apache/arrow/vector/util/JsonStringHashMap.java b/java/vector/src/main/java/org/apache/arrow/vector/util/JsonStringHashMap.java
index 750dd59..e8ce522 100644
--- a/java/vector/src/main/java/org/apache/arrow/vector/util/JsonStringHashMap.java
+++ b/java/vector/src/main/java/org/apache/arrow/vector/util/JsonStringHashMap.java
@@ -46,7 +46,7 @@
if (!(obj instanceof Map)) {
return false;
}
- Map other = (Map) obj;
+ Map<?, ?> other = (Map<?, ?>) obj;
if (this.size() != other.size()) {
return false;
}