commit 6ade07162908b28259fe15f1f5ae670788dd7cd5
author William A. Rowe Jr <wrowe@apache.org> Wed Jun 08 17:37:26 2016 +0000
committer William A. Rowe Jr <wrowe@apache.org> Wed Jun 08 17:37:26 2016 +0000
tree 1aca7ff14da9bca6dcfc64ece1ea85029ade77f6
parent f8f9ec1f249dd552065aa37c983bed4d4d869bb0

17% speedup by eliminating redundant eos test

git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1747424 13f79535-47bb-0310-9956-ffa450edef68

strings/apr_cstr.c

diff --git a/strings/apr_cstr.c b/strings/apr_cstr.c
index 1e0de5a..6c27702 100644
--- a/strings/apr_cstr.c
+++ b/strings/apr_cstr.c
@@ -286,7 +286,8 @@
         const int c1 = (int)(*((const unsigned char *)str1++));
         const int c2 = (int)(*((const unsigned char *)str2++));
         const int cmp = ucharmap[c1] - ucharmap[c2];
-        if (cmp || !c1 || !c2)
+        /* Not necessary to test for !c2, this is caught by cmp */
+        if (cmp || !c1)
             return cmp;
     }
 }
@@ -298,7 +299,8 @@
         const int c1 = (int)(*((const unsigned char *)str1++));
         const int c2 = (int)(*((const unsigned char *)str2++));
         const int cmp = ucharmap[c1] - ucharmap[c2];
-        if (cmp || !c1 || !c2)
+        /* Not necessary to test for !c2, this is caught by cmp */
+        if (cmp || !c1)
             return cmp;
     }
     return 0;