commit 09e4322b4dd6153135c4090d7750f00562150195
author Hans Brende <hansbrende@apache.org> Fri Apr 23 09:00:54 2021 -0500
committer GitHub <noreply@github.com> Fri Apr 23 09:00:54 2021 -0500
tree dbb6e956a3700c481073e64a90f9affb260d53b7
parent 1efe1ff2e43755803fc65755aeb79f909e4d8283
parent 1b906fa9ff39519ec1331533a0f9ba01f4913572

Merge pull request #172 from kamaci/fix/performance_string_concatenation

[ANY23-465] StringBuilder is Used Instead of String Concatenation at Loop

core/src/main/java/org/apache/any23/extractor/html/HTMLDocument.java

diff --git a/core/src/main/java/org/apache/any23/extractor/html/HTMLDocument.java b/core/src/main/java/org/apache/any23/extractor/html/HTMLDocument.java
index 9d4d208..9a35807 100644
--- a/core/src/main/java/org/apache/any23/extractor/html/HTMLDocument.java
+++ b/core/src/main/java/org/apache/any23/extractor/html/HTMLDocument.java
@@ -75,10 +75,10 @@
         // first check if there are values inside
         List<Node> values = DomUtils.findAllByClassName(node, "value");
         if (!values.isEmpty()) {
-            String val = "";
+            StringBuilder val = new StringBuilder();
             for (Node n : values)
-                val += n.getTextContent();
-            return new TextField(val.trim(), node);
+                val.append(n.getTextContent());
+            return new TextField(val.toString().trim(), node);
         }
         if ("ABBR".equals(name) && (null != attributes.getNamedItem("title"))) {
             result = new TextField(attributes.getNamedItem("title").getNodeValue(), node);