Bump plugin versions (#2102)
* Bump plugin versions to latest
* Update spotbugs filters for updated spotbugs version
* Fix spotbugs issue with non-public main class ConfigurationDocGen
* Fix checkstyle issues for updated checkstyle version
* Remove unused import
diff --git a/core/src/main/java/org/apache/accumulo/core/conf/ConfigurationDocGen.java b/core/src/main/java/org/apache/accumulo/core/conf/ConfigurationDocGen.java
index 738f1b5..995cbde 100644
--- a/core/src/main/java/org/apache/accumulo/core/conf/ConfigurationDocGen.java
+++ b/core/src/main/java/org/apache/accumulo/core/conf/ConfigurationDocGen.java
@@ -33,7 +33,7 @@
* This class generates documentation to inform users of the available configuration properties in a
* presentable form.
*/
-class ConfigurationDocGen {
+public class ConfigurationDocGen {
private abstract class Format {
abstract void beginSection(String section);
diff --git a/core/src/main/spotbugs/exclude-filter.xml b/core/src/main/spotbugs/exclude-filter.xml
index 2b6cb2d..f0ccc5b 100644
--- a/core/src/main/spotbugs/exclude-filter.xml
+++ b/core/src/main/spotbugs/exclude-filter.xml
@@ -110,4 +110,8 @@
<!-- https://github.com/spotbugs/spotbugs/issues/756 -->
<Bug pattern="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE" />
</Match>
+ <Match>
+ <!-- More convenient to ignore these everywhere, because it's very common and unimportant -->
+ <Bug pattern="JUA_DONT_ASSERT_INSTANCEOF_IN_TESTS" />
+ </Match>
</FindBugsFilter>
diff --git a/pom.xml b/pom.xml
index a80552d..47441b0 100644
--- a/pom.xml
+++ b/pom.xml
@@ -572,12 +572,12 @@
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>versions-maven-plugin</artifactId>
- <version>2.7</version>
+ <version>2.8.1</version>
</plugin>
<plugin>
<groupId>org.gaul</groupId>
<artifactId>modernizer-maven-plugin</artifactId>
- <version>1.8.0</version>
+ <version>2.1.0</version>
<configuration>
<javaVersion>${maven.compiler.target}</javaVersion>
</configuration>
@@ -585,7 +585,7 @@
<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
- <version>4.0.0</version>
+ <version>4.2.0</version>
<configuration>
<xmlOutput>true</xmlOutput>
<effort>Max</effort>
@@ -597,7 +597,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
- <version>3.1.0</version>
+ <version>3.1.2</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
@@ -608,7 +608,7 @@
<plugin>
<groupId>com.github.ekryd.sortpom</groupId>
<artifactId>sortpom-maven-plugin</artifactId>
- <version>2.10.0</version>
+ <version>2.13.1</version>
<configuration>
<predefinedSortOrder>recommended_2008_06</predefinedSortOrder>
<createBackupFile>false</createBackupFile>
@@ -623,7 +623,7 @@
<plugin>
<groupId>com.github.koraktor</groupId>
<artifactId>mavanagaiata</artifactId>
- <version>0.9.4</version>
+ <version>1.0.0</version>
<configuration>
<skipNoGit>true</skipNoGit>
</configuration>
@@ -731,18 +731,17 @@
<plugin>
<groupId>org.asciidoctor</groupId>
<artifactId>asciidoctor-maven-plugin</artifactId>
- <version>2.0.0</version>
+ <version>2.1.0</version>
</plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>build-helper-maven-plugin</artifactId>
- <version>3.0.0</version>
+ <version>3.2.0</version>
</plugin>
<plugin>
- <!-- version 1.6.0 is broken; see https://github.com/mojohaus/exec-maven-plugin/issues/75 -->
<groupId>org.codehaus.mojo</groupId>
<artifactId>exec-maven-plugin</artifactId>
- <version>1.5.0</version>
+ <version>3.0.0</version>
</plugin>
<plugin>
<groupId>net.revelc.code</groupId>
@@ -752,7 +751,7 @@
<plugin>
<groupId>net.revelc.code.formatter</groupId>
<artifactId>formatter-maven-plugin</artifactId>
- <version>2.12.2</version>
+ <version>2.15.0</version>
<configuration>
<configFile>${eclipseFormatterStyle}</configFile>
<compilerCompliance>${maven.compiler.source}</compilerCompliance>
@@ -791,7 +790,7 @@
<plugin>
<groupId>net.revelc.code</groupId>
<artifactId>impsort-maven-plugin</artifactId>
- <version>1.4.1</version>
+ <version>1.6.1</version>
<configuration>
<removeUnused>true</removeUnused>
<groups>java.,javax.,org.,com.</groups>
@@ -929,8 +928,7 @@
<module name="NoLineWrap" />
<module name="LeftCurly" />
<module name="RightCurly">
- <property name="option" value="alone" />
- <property name="tokens" value="CLASS_DEF, METHOD_DEF, CTOR_DEF, LITERAL_FOR, LITERAL_WHILE, STATIC_INIT, INSTANCE_INIT" />
+ <property name="tokens" value="LITERAL_TRY, LITERAL_CATCH, LITERAL_FINALLY, LITERAL_IF, LITERAL_ELSE, CLASS_DEF, METHOD_DEF, CTOR_DEF, LITERAL_FOR, LITERAL_WHILE, LITERAL_DO, STATIC_INIT, INSTANCE_INIT" />
</module>
<module name="SeparatorWrap">
<property name="tokens" value="DOT" />
@@ -948,12 +946,9 @@
</module>
<module name="NonEmptyAtclauseDescription" />
<module name="JavadocMethod">
- <property name="allowMissingJavadoc" value="true" />
<property name="allowMissingParamTags" value="true" />
- <property name="allowMissingThrowsTags" value="true" />
<property name="allowMissingReturnTag" value="true" />
<property name="allowedAnnotations" value="Override,Test,BeforeClass,AfterClass,Before,After" />
- <property name="allowThrowsTagsForSubclasses" value="true" />
</module>
<module name="MissingOverrideCheck" />
</module>
@@ -967,7 +962,7 @@
<dependency>
<groupId>com.puppycrawl.tools</groupId>
<artifactId>checkstyle</artifactId>
- <version>8.18</version>
+ <version>8.42</version>
</dependency>
</dependencies>
<executions>
diff --git a/server/base/src/main/java/org/apache/accumulo/server/master/balancer/HostRegexTableLoadBalancer.java b/server/base/src/main/java/org/apache/accumulo/server/master/balancer/HostRegexTableLoadBalancer.java
index b335d82..3e5d6cf 100644
--- a/server/base/src/main/java/org/apache/accumulo/server/master/balancer/HostRegexTableLoadBalancer.java
+++ b/server/base/src/main/java/org/apache/accumulo/server/master/balancer/HostRegexTableLoadBalancer.java
@@ -34,7 +34,6 @@
import org.apache.accumulo.core.client.admin.TableOperations;
import org.apache.accumulo.core.conf.AccumuloConfiguration;
-import org.apache.accumulo.core.conf.ConfigurationObserver;
import org.apache.accumulo.core.conf.Property;
import org.apache.accumulo.core.data.impl.KeyExtent;
import org.apache.accumulo.core.master.thrift.TableInfo;
diff --git a/shell/src/main/spotbugs/exclude-filter.xml b/shell/src/main/spotbugs/exclude-filter.xml
index e21ccff..aed069e 100644
--- a/shell/src/main/spotbugs/exclude-filter.xml
+++ b/shell/src/main/spotbugs/exclude-filter.xml
@@ -20,4 +20,8 @@
<Class name="org.apache.accumulo.shell.Shell" />
<Bug code="DM" pattern="DM_EXIT" />
</Match>
+ <Match>
+ <!-- More convenient to ignore these everywhere, because it's very common and unimportant -->
+ <Bug pattern="JUA_DONT_ASSERT_INSTANCEOF_IN_TESTS" />
+ </Match>
</FindBugsFilter>
diff --git a/start/src/main/spotbugs/exclude-filter.xml b/start/src/main/spotbugs/exclude-filter.xml
new file mode 100644
index 0000000..4847769
--- /dev/null
+++ b/start/src/main/spotbugs/exclude-filter.xml
@@ -0,0 +1,22 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<FindBugsFilter>
+ <Match>
+ <!-- More convenient to ignore these everywhere, because it's very common and unimportant -->
+ <Bug pattern="JUA_DONT_ASSERT_INSTANCEOF_IN_TESTS" />
+ </Match>
+</FindBugsFilter>
diff --git a/test/src/main/spotbugs/exclude-filter.xml b/test/src/main/spotbugs/exclude-filter.xml
index a53d038..72d133f 100644
--- a/test/src/main/spotbugs/exclude-filter.xml
+++ b/test/src/main/spotbugs/exclude-filter.xml
@@ -53,4 +53,8 @@
<!-- https://github.com/spotbugs/spotbugs/issues/756 -->
<Bug pattern="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE" />
</Match>
+ <Match>
+ <!-- More convenient to ignore these everywhere, because it's very common and unimportant -->
+ <Bug pattern="JUA_DONT_ASSERT_INSTANCEOF_IN_TESTS" />
+ </Match>
</FindBugsFilter>
