commit 898cdedd5fc1c22cfb755893bda35e91112a994c
author Dom G <domgarguilo@apache.org> Thu Apr 11 14:58:55 2024 -0400
committer GitHub <noreply@github.com> Thu Apr 11 14:58:55 2024 -0400
tree 681551b4ce48939b4587a4c1f0f4be0aa3f2aaaa
parent ce95056c57d3eff61400486b4a9da8fd73dbe67e

Fix deprecated props, use fluent-style threadpool builder (#273)

Co-authored-by: Dominic Garguilo <Dominic Garguilo>

src/main/java/org/apache/accumulo/testing/randomwalk/Module.java

diff --git a/src/main/java/org/apache/accumulo/testing/randomwalk/Module.java b/src/main/java/org/apache/accumulo/testing/randomwalk/Module.java
index 5861ee2..aec30a3 100644
--- a/src/main/java/org/apache/accumulo/testing/randomwalk/Module.java
+++ b/src/main/java/org/apache/accumulo/testing/randomwalk/Module.java
@@ -220,8 +220,8 @@
       fixture.setUp(state, env);
     }
 
-    ExecutorService service =
-        ThreadPools.getServerThreadPools().createFixedThreadPool(1, "RandomWalk Runner", false);
+    ExecutorService service = ThreadPools.getServerThreadPools().getPoolBuilder("RandomWalk Runner")
+        .numCoreThreads(1).build();
 
     try {
       Node initNode = getNode(initNodeId);

src/main/java/org/apache/accumulo/testing/randomwalk/bulk/Setup.java

diff --git a/src/main/java/org/apache/accumulo/testing/randomwalk/bulk/Setup.java b/src/main/java/org/apache/accumulo/testing/randomwalk/bulk/Setup.java
index 019ce4a..3c6d46a 100644
--- a/src/main/java/org/apache/accumulo/testing/randomwalk/bulk/Setup.java
+++ b/src/main/java/org/apache/accumulo/testing/randomwalk/bulk/Setup.java
@@ -61,8 +61,8 @@
     state.set("fs", FileSystem.get(env.getHadoopConfiguration()));
     state.set("bulkImportSuccess", "true");
     BulkPlusOne.counter.set(0L);
-    ThreadPoolExecutor e = ThreadPools.getServerThreadPools().createFixedThreadPool(MAX_POOL_SIZE,
-        "bulkImportPool", false);
+    ThreadPoolExecutor e = ThreadPools.getServerThreadPools().getPoolBuilder("bulkImportPool")
+        .numCoreThreads(MAX_POOL_SIZE).build();
     state.set("pool", e);
   }
 

src/main/java/org/apache/accumulo/testing/randomwalk/concurrent/Config.java

diff --git a/src/main/java/org/apache/accumulo/testing/randomwalk/concurrent/Config.java b/src/main/java/org/apache/accumulo/testing/randomwalk/concurrent/Config.java
index ccd3d81..4abba0d 100644
--- a/src/main/java/org/apache/accumulo/testing/randomwalk/concurrent/Config.java
+++ b/src/main/java/org/apache/accumulo/testing/randomwalk/concurrent/Config.java
@@ -65,6 +65,9 @@
   final Property TSERV_COMPACTION_SERVICE_DEFAULT_EXECUTORS_deprecated =
       Property.TSERV_COMPACTION_SERVICE_DEFAULT_EXECUTORS;
 
+  @SuppressWarnings("deprecation")
+  final Property TSERV_WORKQ_THREADS_deprecated = Property.TSERV_WORKQ_THREADS;
+
   // @formatter:off
   final Setting[] settings = {
 			s(Property.TSERV_BLOOM_LOAD_MAXCONCURRENT, 1, 10),
@@ -89,7 +92,7 @@
 			s(Property.TSERV_WAL_SORT_BUFFER_SIZE, 1024 * 1024, 1024 * 1024 * 1024L),
 			s(Property.TSERV_TABLET_SPLIT_FINDMIDPOINT_MAXOPEN, 5, 100),
 			s(Property.TSERV_WAL_BLOCKSIZE, 1024 * 1024,1024 * 1024 * 1024 * 10L),
-			s(Property.TSERV_WORKQ_THREADS, 1, 10),
+			s(TSERV_WORKQ_THREADS_deprecated, 1, 10),
 			s(Property.MANAGER_BULK_TIMEOUT, 10, 600),
 			s(Property.MANAGER_FATE_THREADPOOL_SIZE, 1, 100),
 			s(Property.MANAGER_RECOVERY_DELAY, 0, 100),