commit 044bd9833573dd6a497876ead174e237339bad3d
author Guangya Liu <gyliu513@gmail.com> Fri Jul 29 13:39:57 2016 -0700
committer Benjamin Mahler <bmahler@apache.org> Fri Jul 29 13:39:57 2016 -0700
tree 3fab6af90d69cf29b82f0bf5bb3895b8124a1323
parent 93d69595904e951e90b3a6e878fec04918231201

Used `add` instead of `+=` for `Resources::filter`.

The current logic of `Resources::filter` is using `+=` to add
the filtered resource object and the `+=` resource object will
invoke `validate` which is not necessary as all of the resource
objects are valid.

The fix is using `add` instead of `+=` for `Resources::filter`,
this can make sure there is no validation and can improve
performance of `Resources::filter` for resources object.

Review: https://reviews.apache.org/r/50557/

src/common/resources.cpp

diff --git a/src/common/resources.cpp b/src/common/resources.cpp
index 1fe7909..69166de 100644
--- a/src/common/resources.cpp
+++ b/src/common/resources.cpp
@@ -849,7 +849,7 @@
   Resources result;
   foreach (const Resource& resource, resources) {
     if (predicate(resource)) {
-      result += resource;
+      result.add(resource);
     }
   }
   return result;

src/v1/resources.cpp

diff --git a/src/v1/resources.cpp b/src/v1/resources.cpp
index c62bc35..90897e3 100644
--- a/src/v1/resources.cpp
+++ b/src/v1/resources.cpp
@@ -852,7 +852,7 @@
   Resources result;
   foreach (const Resource& resource, resources) {
     if (predicate(resource)) {
-      result += resource;
+      result.add(resource);
     }
   }
   return result;