commit a76f14bf284ea32bec553b7be8ecce152d40a751
author Hervé Boutemy <hboutemy@apache.org> Wed Apr 22 08:42:51 2020 +0200
committer Hervé Boutemy <hboutemy@apache.org> Sun Dec 27 18:47:48 2020 +0100
tree de6ebe8b88983437eccb515c64bbaf1ec02578d9
parent ecaad5ddd874832e71870d0b20f02cac5a9f5101

[MNG-5001] short circuit to focus on read-only parameter with config

maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultMavenPluginManager.java

diff --git a/maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultMavenPluginManager.java b/maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultMavenPluginManager.java
index 788aadd..89d8d0d 100644
--- a/maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultMavenPluginManager.java
+++ b/maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultMavenPluginManager.java
@@ -770,16 +770,24 @@
 
         for ( Parameter parameter : mojoDescriptor.getParameters() )
         {
-            PlexusConfiguration config = configuration.getChild( parameter.getName(), false );
-            if ( config != null && !parameter.isEditable() )
+            if ( parameter.isEditable() )
             {
-                String value = config.getValue( null );
-                String defaultValue = config.getAttribute( "default-value", null );
-                if ( value != null && defaultValue != null && !Objects.equals( defaultValue, value ) )
-                {
-                    invalidParameters.add( parameter );
-                    logger.error( "Setting read-only parameter '" + parameter.getName() + "' to " + value );
-                }
+                // mojo parameter not read-only: ignore
+                continue;
+            }
+            PlexusConfiguration config = configuration.getChild( parameter.getName(), false );
+            if ( config == null )
+            {
+              // parameter not configured: ignore
+              continue;
+            }
+
+            String value = config.getValue( null );
+            String defaultValue = config.getAttribute( "default-value", null );
+            if ( value != null && defaultValue != null && !Objects.equals( defaultValue, value ) )
+            {
+                invalidParameters.add( parameter );
+                logger.error( "Setting read-only parameter '" + parameter.getName() + "' to " + value );
             }
         }