commit b9ecdf134a2f53a57ebad8e08ab61e3e3118dc2e
author rakechan <rakechan@gmail.com> Sat Jul 09 23:24:05 2016 +0530
committer Jean-Baptiste Onofré <jbonofre@apache.org> Tue Jul 12 18:46:59 2016 +0200
tree c00e84d9ba00c1042940962cb53e3acd71381ed0
parent d9a57d1647722783f51d1e75c907dfef25fc4b00

[KARAF-4528] Fix CaveRepositoryMBeanImpl to avoid to throw undesired IllegalArgumentException

server/management/src/main/java/org/apache/karaf/cave/server/management/internal/CaveRepositoryMBeanImpl.java

diff --git a/server/management/src/main/java/org/apache/karaf/cave/server/management/internal/CaveRepositoryMBeanImpl.java b/server/management/src/main/java/org/apache/karaf/cave/server/management/internal/CaveRepositoryMBeanImpl.java
index cb2d403..f0ab7f0 100644
--- a/server/management/src/main/java/org/apache/karaf/cave/server/management/internal/CaveRepositoryMBeanImpl.java
+++ b/server/management/src/main/java/org/apache/karaf/cave/server/management/internal/CaveRepositoryMBeanImpl.java
@@ -84,28 +84,28 @@
     }
 
     public void destroyRepository(String name) throws Exception {
-        if (getCaveRepositoryService().getRepository(name) != null) {
+        if (getCaveRepositoryService().getRepository(name) == null) {
             throw new IllegalArgumentException("Cave repository " + name + " doesn't exist");
         }
         caveRepositoryService.destroy(name);
     }
 
     public void installRepository(String name) throws Exception {
-        if (getCaveRepositoryService().getRepository(name) != null) {
+        if (getCaveRepositoryService().getRepository(name) == null) {
             throw new IllegalArgumentException("Cave repository " + name + " doesn't exist");
         }
         caveRepositoryService.install(name);
     }
 
     public void uninstallRepository(String name) throws Exception {
-        if (getCaveRepositoryService().getRepository(name) != null) {
+        if (getCaveRepositoryService().getRepository(name) == null) {
             throw new IllegalArgumentException("Cave repository " + name + " doesn't exist");
         }
         caveRepositoryService.uninstall(name);
     }
 
     public void populateRepository(String name, String url, boolean generate, String filter) throws Exception {
-        if (getCaveRepositoryService().getRepository(name) != null) {
+        if (getCaveRepositoryService().getRepository(name) == null) {
             throw new IllegalArgumentException("Cave repository " + name + " doesn't exist");
         }
         CaveRepository repository = getCaveRepositoryService().getRepository(name);
@@ -116,7 +116,7 @@
     }
 
     public void proxyRepository(String name, String url, boolean generate, String filter) throws Exception {
-        if (getCaveRepositoryService().getRepository(name) != null) {
+        if (getCaveRepositoryService().getRepository(name) == null) {
             throw new IllegalArgumentException("Cave repository " + name + " doesn't exist");
         }
         CaveRepository repository = getCaveRepositoryService().getRepository(name);
@@ -127,7 +127,7 @@
     }
 
     public void updateRepository(String name) throws Exception {
-        if (getCaveRepositoryService().getRepository(name) != null) {
+        if (getCaveRepositoryService().getRepository(name) == null) {
             throw new IllegalArgumentException("Cave repository " + name + " doesn't exist");
         }
         CaveRepository caveRepository = getCaveRepositoryService().getRepository(name);
@@ -135,7 +135,7 @@
     }
 
     public void uploadArtifact(String repository, String artifactUrl, boolean generate) throws Exception {
-        if (getCaveRepositoryService().getRepository(repository) != null) {
+        if (getCaveRepositoryService().getRepository(repository) == null) {
             throw new IllegalArgumentException("Cave repository " + repository + " doesn't exist");
         }
         CaveRepository caveRepository = getCaveRepositoryService().getRepository(repository);