commit 88371c2f90be1ba591056635a04b17cbb25926a1
author Gary Gregory <garydgregory@gmail.com> Sun Feb 04 14:08:50 2024 -0500
committer Gary Gregory <garydgregory@gmail.com> Sun Feb 04 14:08:50 2024 -0500
tree 72b28e8f454542e436c133796624b862d5df1548
parent c5b5ee7d4b63169189553a0318a9a084f951724a

Remove variable assignment just before returning it

src/main/java/org/apache/commons/validator/routines/ISSNValidator.java

diff --git a/src/main/java/org/apache/commons/validator/routines/ISSNValidator.java b/src/main/java/org/apache/commons/validator/routines/ISSNValidator.java
index 78f11e2..749da0f 100644
--- a/src/main/java/org/apache/commons/validator/routines/ISSNValidator.java
+++ b/src/main/java/org/apache/commons/validator/routines/ISSNValidator.java
@@ -158,8 +158,7 @@
             final String issnBase = input.substring(3, 10); // TODO: how to derive these
             //CHECKSTYLE:ON: MagicNumber
             final String checkDigit = ISSNCheckDigit.ISSN_CHECK_DIGIT.calculate(issnBase);
-            final String issn = issnBase + checkDigit;
-            return issn;
+            return issnBase + checkDigit;
         } catch (final CheckDigitException e) { // Should not happen
             throw new IllegalArgumentException("Check digit error for '" + ean13 + "' - " + e.getMessage());
         }