[DIGESTER-173] added a testcase that demonstrates DTD validation suppression - props to Ivan Diana that submitted the patch
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/digester/trunk@1457663 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/core/src/test/java/org/apache/commons/digester3/DTDValidationTestCase.java b/core/src/test/java/org/apache/commons/digester3/DTDValidationTestCase.java
index e06351c..56413ab 100644
--- a/core/src/test/java/org/apache/commons/digester3/DTDValidationTestCase.java
+++ b/core/src/test/java/org/apache/commons/digester3/DTDValidationTestCase.java
@@ -1,4 +1,4 @@
-/*
+/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
@@ -110,4 +110,26 @@
.parse( new File( "src/test/resources/org/apache/commons/digester3/document-with-relative-dtd.xml" ) );
}
+ @Test
+ public void testDigesterLoaderFeatureDisabled()
+ throws Exception
+ {
+ newLoader( new AbstractRulesModule()
+ {
+
+ @Override
+ protected void configure()
+ {
+ // do nothing
+ }
+
+ } )
+ .setFeature("http://xml.org/sax/features/validation", false)
+ .setFeature("http://xml.org/sax/features/external-parameter-entities", false)
+ .setFeature("http://apache.org/xml/features/nonvalidating/load-dtd-grammar", false)
+ .setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false)
+ .newDigester()
+ .parse( new File( "src/test/resources/org/apache/commons/digester3/document-with-relative-dtd-error.xml" ) );
+ }
+
}
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index e5a8187..91ba695 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -29,8 +29,8 @@
<action dev="simonetripodi" type="fix" issue="DIGESTER-174" due-to="Andreas Sahlbach">
Inner List Annotation has wrong @Target for most of the predefined annotation rules
</action>
- <action dev="simonetripodi" type="fix" issue="DIGESTER-173" due-to="Ivan Diana">
- No way to enable schema validation from DigesterLoader
+ <action dev="simonetripodi" type="fix" issue="DIGESTER-173" due-to="Nick Williams">
+ No way to enable schema validation from DigesterLoader - patch provided by Ivan Diana
</action>
<action dev="simonetripodi" type="fix" issue="DIGESTER-172" due-to="Ivan Diana">
Even with custom ErrorHandler, SAX errors are still written to stderr
