Google Git
Sign in
apache / zookeeper / c234848caef0cc920f19befd1b0b14251b17da92
commitc234848caef0cc920f19befd1b0b14251b17da92[log] [tgz]
authorDamien Diederen <dd@crosstwine.com>Wed Jan 22 12:53:55 2020 +0100
committerNorbert Kalmar <nkalmar@apache.org>Wed Jan 22 12:53:55 2020 +0100
tree828dd02cca71dab3376e1c82753649cc941a975a
parentb7dd0e49c5b25fffc1be8e619a3164bc680ef8bd [diff]
ZOOKEEPER-1112: Add (Cyrus) SASL authentication support to C client library

This is a "respin" of https://github.com/apache/zookeeper/pull/1054, which I withdrew due to some annoying shortcomings.

This changeset allows C clients to use SASL to authenticate with the ZooKeeper server.  It is loosely based on patches #1 and #2 by Tom Klonikowski, at https://reviews.apache.org/r/2252/, but the result has been extensively reworked to follow the semantics of the Java client:

  * No SASL operations are exposed through the API;

  * The configuration is provided, and stored, at "handle init time";

  * SASL authentication is automatically performed after each (re)connect.

It introduces an optional dependency on the Cyrus SASL library, which can either be autodetected (default) or configured using the `--without-sasl`/`--with-sasl[=DIR]` flags, or -DWITH_CYRUS_SASL for CMake/Windows.

`TestServerRequireClientSASLAuth.cc` has been renamed to `TestSASLAuth.cc`, and a test has been added which successfully (re)authenticates using the `DIGEST-MD5` mechanism.  The code has also been used to successfully authenticate clients via `GSSAPI`/Kerberos.

This commit also adds SASL support to the `cli.c` client.

Co-authored-by: Tom Klonikowski <klonik_tinformatik.haw-hamburg.de>

Author: Damien Diederen <dd@crosstwine.com>

Reviewers: Mate Szalay-Beko <szalay.beko.mate@gmail.com>, Norbert Kalmar <nkalmar@apache.org>

Closes #1134 from ztzg/ZOOKEEPER-1112-c-client-sasl-support-v2
20 files changed
tree: 828dd02cca71dab3376e1c82753649cc941a975a
  1. bin/
  2. conf/
  3. dev/
  4. tools/
  5. zookeeper-assembly/
  6. zookeeper-client/
  7. zookeeper-contrib/
  8. zookeeper-docs/
  9. zookeeper-it/
  10. zookeeper-jute/
  11. zookeeper-metrics-providers/
  12. zookeeper-recipes/
  13. zookeeper-server/
  14. .gitattributes
  15. .gitignore
  16. .travis.yml
  17. checkstyle-simple.xml
  18. checkstyle-strict.xml
  19. checkstyleSuppressions.xml
  20. excludeFindBugsFilter.xml
  21. LICENSE.txt
  22. NOTICE.txt
  23. owaspSuppressions.xml
  24. pom.xml
  25. README.md
  26. README_packaging.md
  27. zk-merge-pr.py
README.md

Apache ZooKeeper Build Status Maven Central License

alt text

For the latest information about Apache ZooKeeper, please visit our website at:

http://zookeeper.apache.org/

and our wiki, at:

https://cwiki.apache.org/confluence/display/ZOOKEEPER

Packaging/release artifacts

Either downloaded from https://zookeeper.apache.org/releases.html or found in zookeeper-assembly/target directory after building the project with maven.

apache-zookeeper-[version].tar.gz

    Contains all the source files which can be built by running:
    mvn clean install

    To generate an aggregated apidocs for zookeeper-server and zookeeper-jute:
    mvn javadoc:aggregate
    (generated files will be at target/site/apidocs)

apache-zookeeper-[version]-bin.tar.gz

    Contains all the jar files required to run ZooKeeper
    Full documentation can also be found in the docs folder

As of version 3.5.5, the parent, zookeeper and zookeeper-jute artifacts are deployed to the central repository after the release is voted on and approved by the Apache ZooKeeper PMC:

https://repo1.maven.org/maven2/org/apache/zookeeper/zookeeper/

Java 8

If you are going to compile with Java 1.8, you should use a recent release at u211 or above.

Contributing

We always welcome new contributors to the project! See How to Contribute for details on how to submit patch through pull request and our contribution workflow.