| commit | 3ad1a2c486398a39db29dd82ff0a3e617a6e346a | [log] [tgz] |
|---|---|---|
| author | ChanHo Lee <chanholee@apache.org> | Tue Oct 07 11:45:39 2025 +0900 |
| committer | GitHub <noreply@github.com> | Tue Oct 07 11:45:39 2025 +0900 |
| tree | 44746bb388731dec3735dc1d921d2ebe8b87ce51 | |
| parent | 9aac655ef9fce3cdb91f4fac3dbc4a6fff9c3d1e [diff] |
[ZEPPELIN-6351] Close modals only on their own user actions ### What is this PR for? On the home page, an open modal (e.g., `Import Note`, `Create New Note`) closes when a `NOTES_INFO` message is received. This is unexpected and makes running parallel E2E tests that create new notes unreliable. #### Root cause Both modals treated any `NOTES_INFO` message as the result of *their* own submit action. Since `NOTES_INFO` message is broadcast for various events, this led to false positives. #### Fix Close modals only in response to messages addressed to the submitting client: `IMPORT_NOTE` and `NEW_NOTE`. The server already sends `NEW_NOTE` (used by the old UI), but not `IMPORT_NOTE`. I added a server-sent `IMPORT_NOTE` and replaced `broadcastNote(note)` with sending `IMPORT_NOTE` only to the caller. The previously broadcast `NOTE` is mainly useful to users already on that note page; for a newly imported note, no user is on that page yet, so the broadcast is unnecessary. ### What type of PR is it? Bug Fix ### What is the Jira issue? [[ZEPPELIN-6351]](https://issues.apache.org/jira/browse/ZEPPELIN-6351) ### How should this be tested? - Open two browser windows (A and B). - In A, open a modal (e.g., Import Note or Create New Note). - In B, perform a submit that triggers a note update. Verify the modal in A does not close. - In A, submit the modal. Verify it closes and the note list updates. ### Screenshots (if appropriate) #### [AS-IS] https://github.com/user-attachments/assets/a38a8334-81d3-45ae-9264-755143df9041 #### [TO-BE] https://github.com/user-attachments/assets/b5e9148a-2a2a-441c-a389-aa1f558a025d ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Closes #5092 from tbonelee/fix-modal-close. Signed-off-by: ChanHo Lee <chanholee@apache.org>
Documentation: User Guide
Mailing Lists: User and Dev mailing list
Continuous Integration:
Contributing: Contribution Guide
Issue Tracker: Jira
License: Apache 2.0
Zeppelin, a web-based notebook that enables interactive data analytics. You can make beautiful data-driven, interactive and collaborative documents with SQL, Scala and more.
Core features:
To know more about Zeppelin, visit our web site https://zeppelin.apache.org
Please go to install to install Apache Zeppelin from binary package.
Please check Build from source to build Zeppelin from source.